Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bgp help text to reflect Cilium minimum version for feature #1924

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Update bgp help text to reflect Cilium minimum version for feature #1924

merged 1 commit into from
Aug 25, 2023

Conversation

barajus
Copy link
Contributor

@barajus barajus commented Aug 18, 2023

Follow-up on #1902
Add an explicit comment for the version requirement

@barajus
Update bgp.go#2
d2d2420 
Follow-up on #1902
Add an explicit comment

Signed-off-by: Julien D. <barajus@users.noreply.github.com>
@barajus barajus requested a review from a team as a code owner August 18, 2023 14:01
@barajus barajus requested a review from squeed August 18, 2023 14:01
@barajus barajus temporarily deployed to ci August 18, 2023 14:01 — with GitHub Actions Inactive
@barajus barajus mentioned this pull request Aug 18, 2023
Closed
@joestringer
Copy link
Member

Thanks @barajus !

@joestringer joestringer merged commit 0e6479e into cilium:main Aug 25, 2023
@joestringer joestringer changed the title Update bgp.go#2 Update bgp help text to reflect Cilium minimum version for feature Aug 25, 2023
@barajus barajus deleted the barajus-patch-1-1 branch August 28, 2023 08:55
@p-linnane p-linnane mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barajus @joestringer @squeed