Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usecases #288

Merged
merged 40 commits into from
Jun 19, 2023
Merged

Usecases #288

merged 40 commits into from
Jun 19, 2023

Conversation

paularah
Copy link
Collaborator

@paularah paularah commented Jun 8, 2023

@hacktivist123
Copy link
Member

Hey @paularah Great job so far, I've reviewed your code and the content of the page. here are some observations that I discussed with @xmulligan

  • The runtime enforcement page, The "Security Observability and Runtime Enforcement with Cilium’s Tetragon" block should be on the right-hand side and the video should be on the left-hand side. This is based on the design I can see on Figma.

  • Same with the "Kubernetes-Aware Real Time Enforcement" block on that same page. The text should be on the left and the image should be on the right.

  • In the "Service Map" page, the text in the "Service Dependency Graph" section should be on the right and the image/video on the left

  • In the "Metrics and tracing export" page, the image in the "Comprehensive & Rich Set Of Metrics" should be on the right and the text on the left. Same with the video and text in the next section of that same page

  • In the "protocol visibility" page, the text in the "Gain Deep Insights Into Your Workload Communication At The Protocol Level With Cilium" section should be on the left and the image should be on the right.

  • In the "BGP" page of the use cases, the text in the "Effortless Integration of Existing Network Infrastructure" section should be on the right and the image should be on the left.

These are all my observations for now, let me know if you need more clarity.

Also, I'll take a look at the fixes you made.

Great work!

@paularah
Copy link
Collaborator Author

Hey @paularah Great job so far, I've reviewed your code and the content of the page. here are some observations that I discussed with @xmulligan

  • The runtime enforcement page, The "Security Observability and Runtime Enforcement with Cilium’s Tetragon" block should be on the right-hand side and the video should be on the left-hand side. This is based on the design I can see on Figma.
  • Same with the "Kubernetes-Aware Real Time Enforcement" block on that same page. The text should be on the left and the image should be on the right.
  • In the "Service Map" page, the text in the "Service Dependency Graph" section should be on the right and the image/video on the left
  • In the "Metrics and tracing export" page, the image in the "Comprehensive & Rich Set Of Metrics" should be on the right and the text on the left. Same with the video and text in the next section of that same page
  • In the "protocol visibility" page, the text in the "Gain Deep Insights Into Your Workload Communication At The Protocol Level With Cilium" section should be on the left and the image should be on the right.
  • In the "BGP" page of the use cases, the text in the "Effortless Integration of Existing Network Infrastructure" section should be on the right and the image should be on the left.

These are all my observations for now, let me know if you need more clarity.

Also, I'll take a look at the fixes you made.

Great work!

Thank you! I made the designs on Figma so things aren't set in stone. I made some last-minute changes while building the pages that I felt were better aesthetically; that's why there are some differences between the Figma designs and the pages.

The rationale is to keep videos on the right as much as possible so it's easier to spot and consistent across pages, while images can float left or right. LMK if you think otherwise.

@hacktivist123
Copy link
Member

Hey @paularah Great job so far, I've reviewed your code and the content of the page. here are some observations that I discussed with @xmulligan

  • The runtime enforcement page, The "Security Observability and Runtime Enforcement with Cilium’s Tetragon" block should be on the right-hand side and the video should be on the left-hand side. This is based on the design I can see on Figma.
  • Same with the "Kubernetes-Aware Real Time Enforcement" block on that same page. The text should be on the left and the image should be on the right.
  • In the "Service Map" page, the text in the "Service Dependency Graph" section should be on the right and the image/video on the left
  • In the "Metrics and tracing export" page, the image in the "Comprehensive & Rich Set Of Metrics" should be on the right and the text on the left. Same with the video and text in the next section of that same page
  • In the "protocol visibility" page, the text in the "Gain Deep Insights Into Your Workload Communication At The Protocol Level With Cilium" section should be on the left and the image should be on the right.
  • In the "BGP" page of the use cases, the text in the "Effortless Integration of Existing Network Infrastructure" section should be on the right and the image should be on the left.

These are all my observations for now, let me know if you need more clarity.

Also, I'll take a look at the fixes you made.

Great work!

Thank you! I made the designs on Figma so things aren't set in stone. I made some last-minute changes while building the pages that I felt were better aesthetically; that's why there are some differences between the Figma designs and the pages.

The rationale is to keep videos on the right as much as possible so it's easier to spot and consistent across pages, while images can float left or right. LMK if you think otherwise.

@paularah I see, that makes sense. I'm really just worried about inconsistency in the pages. If we are sticking to one style of positioning, let's just stick to that. I also noticed some pages where all the images and videos where all floated to the right. So maybe do a quick check and make sure there's consistency in the positioning of the images, text and videos on those pages.

@xmulligan
Copy link
Member

I'm going to merge this so we can do a final check against the main branch

@xmulligan xmulligan merged commit c809a40 into cilium:use-cases Jun 19, 2023
xmulligan added a commit that referenced this pull request Jun 21, 2023
* Usecases (#288)

* feat: use icons for network inlet section

* feat: cni page styling

* feat: add layer load balancer page

* feat: add clutsermesh page

* fix: update file extensions to jsx

* fix: remove unsued imports

* fix: correct type on clickhouse

* feat: break off sections into diiferent components

* fix: alternate image postion with props

* fix: reorg file directory

* feat: cluster mesh page with seperated components

* fix: correct urls and quotes on use cases cards

* fix: images sizes for intro section

* feat: add bandwidth and lantency optimization page

* feat: add kube-proxy-replacement-page contents

* feat: add bgp page

* feat: add egress-gateway-page

* feat: add service mesh page

* chore: remove dead imports

* feat: add gaeway api page

* fix: add image alt for gateway api content image

* feat: add service map page and use cases

* feat: add metrics and tracing export

* feat: add network-flow-logs-page

* feat: add protocol visibility page

* feat: add transparent encryption page

* feat: add network policy editor

* feat: add runtime enforcement page

* fix: give pages component the correct names

* feat: add cni page

* feat: add home feature page

* fix: fix broken links on CNI use case section

* fix: include missing image for service mesh page

* feat: use section components for load balancer page

* fix: style xdp section correctly

* fix: correct text for use case card on cni page

* fix: capitalize use cases card header

* fix: fix prop types for use case card

* fix: correct prefix for gatsby routing

* fix: props for alternating video postition

* Removes unused Faq component breaking the build.  (#292)

* feat: use icons for network inlet section

* feat: cni page styling

* feat: add layer load balancer page

* feat: add clutsermesh page

* fix: update file extensions to jsx

* fix: remove unsued imports

* fix: correct type on clickhouse

* feat: break off sections into diiferent components

* fix: alternate image postion with props

* fix: reorg file directory

* feat: cluster mesh page with seperated components

* fix: correct urls and quotes on use cases cards

* fix: images sizes for intro section

* feat: add bandwidth and lantency optimization page

* feat: add kube-proxy-replacement-page contents

* feat: add bgp page

* feat: add egress-gateway-page

* feat: add service mesh page

* chore: remove dead imports

* feat: add gaeway api page

* fix: add image alt for gateway api content image

* feat: add service map page and use cases

* feat: add metrics and tracing export

* feat: add network-flow-logs-page

* feat: add protocol visibility page

* feat: add transparent encryption page

* feat: add network policy editor

* feat: add runtime enforcement page

* fix: give pages component the correct names

* feat: add cni page

* feat: add home feature page

* fix: fix broken links on CNI use case section

* fix: include missing image for service mesh page

* feat: use section components for load balancer page

* fix: style xdp section correctly

* fix: correct text for use case card on cni page

* fix: capitalize use cases card header

* fix: fix prop types for use case card

* fix: correct prefix for gatsby routing

* fix: props for alternating video postition

* fix: comment out faq component

* Fixes broken build by removing faq component  (#293)

* feat: use icons for network inlet section

* feat: cni page styling

* feat: add layer load balancer page

* feat: add clutsermesh page

* fix: update file extensions to jsx

* fix: remove unsued imports

* fix: correct type on clickhouse

* feat: break off sections into diiferent components

* fix: alternate image postion with props

* fix: reorg file directory

* feat: cluster mesh page with seperated components

* fix: correct urls and quotes on use cases cards

* fix: images sizes for intro section

* feat: add bandwidth and lantency optimization page

* feat: add kube-proxy-replacement-page contents

* feat: add bgp page

* feat: add egress-gateway-page

* feat: add service mesh page

* chore: remove dead imports

* feat: add gaeway api page

* fix: add image alt for gateway api content image

* feat: add service map page and use cases

* feat: add metrics and tracing export

* feat: add network-flow-logs-page

* feat: add protocol visibility page

* feat: add transparent encryption page

* feat: add network policy editor

* feat: add runtime enforcement page

* fix: give pages component the correct names

* feat: add cni page

* feat: add home feature page

* fix: fix broken links on CNI use case section

* fix: include missing image for service mesh page

* feat: use section components for load balancer page

* fix: style xdp section correctly

* fix: correct text for use case card on cni page

* fix: capitalize use cases card header

* fix: fix prop types for use case card

* fix: correct prefix for gatsby routing

* fix: props for alternating video postition

* fix: comment out faq component

* fix: remove faq component entirely

* feat: use icons for network inlet section

* feat: cni page styling

* feat: add layer load balancer page

* feat: add clutsermesh page

* fix: update file extensions to jsx

* fix: remove unsued imports

* fix: correct type on clickhouse

* feat: break off sections into diiferent components

* fix: alternate image postion with props

* fix: reorg file directory

* feat: cluster mesh page with seperated components

* fix: correct urls and quotes on use cases cards

* fix: images sizes for intro section

* feat: add bandwidth and lantency optimization page

* feat: add kube-proxy-replacement-page contents

* feat: add bgp page

* feat: add egress-gateway-page

* feat: add service mesh page

* chore: remove dead imports

* feat: add gaeway api page

* fix: add image alt for gateway api content image

* feat: add service map page and use cases

* feat: add metrics and tracing export

* feat: add network-flow-logs-page

* feat: add protocol visibility page

* feat: add transparent encryption page

* feat: add network policy editor

* feat: add runtime enforcement page

* fix: give pages component the correct names

* feat: add cni page

* feat: add home feature page

* fix: fix broken links on CNI use case section

* fix: include missing image for service mesh page

* feat: use section components for load balancer page

* fix: style xdp section correctly

* fix: correct text for use case card on cni page

* fix: capitalize use cases card header

* fix: fix prop types for use case card

* fix: correct prefix for gatsby routing

* fix: props for alternating video postition

* fix: comment out faq component

* fix: remove faq component entirely

* fix: review corrections pre feedback

* feat: use cases navabar

* fix: smoothen scroll behaviour for usecase navbar

* fix: remove sproutffi from testimonials

* fix: clilium logo for advanced protocol visibility page

* fix spelling

---------

Signed-off-by: Paul Arah <paularah.self@gmail.com>
Co-authored-by: Bill Mulligan <billmulligan516@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants