Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup/ipam: Remove hostscope-legacy IPAM option #12984

Merged
merged 1 commit into from Sep 7, 2020
Merged

cleanup/ipam: Remove hostscope-legacy IPAM option #12984

merged 1 commit into from Sep 7, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Aug 27, 2020 •
edited

To remove hostscope-legacy IPAM option

Fixes: #12974

Signed-off-by: Tam Mach sayboras@yahoo.com

cleanup/ipam: Remove hostscope-legacy IPAM option

TODO:

  • Update docs
  • Test upgrade path

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 27, 2020
@sayboras sayboras added sig/ipam IP address management, including cloud IPAM release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Aug 28, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 28, 2020
@sayboras sayboras force-pushed the cleanup/hostscope-legacy branch 3 times, most recently from eff3310 to a1c85a2 Compare August 31, 2020 11:51
@sayboras
Copy link
Member Author

sayboras commented Sep 1, 2020

test-me-please

@sayboras sayboras marked this pull request as ready for review September 1, 2020 22:33
@sayboras sayboras requested a review from a team September 1, 2020 22:33
@sayboras sayboras requested review from a team as code owners September 1, 2020 22:33
@sayboras sayboras requested review from a team September 1, 2020 22:33
@sayboras sayboras requested a review from a team as a code owner September 1, 2020 22:33
joestringer
joestringer requested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs typos/nits, otherwise LGTM

Documentation/install/upgrade.rst Outdated Show resolved Hide resolved
Documentation/install/upgrade.rst Outdated Show resolved Hide resolved
@sayboras
Copy link
Member Author

sayboras commented Sep 3, 2020

Jenkins jobs are completed successfully, force push to address review comments related to docs.

@aanm
Copy link
Member

aanm commented Sep 3, 2020

test-me-please

@sayboras
Copy link
Member Author

sayboras commented Sep 3, 2020

Failure seems related to #13056

20:17:43  Summarizing 1 Failure:
20:17:43  
20:17:43  [Fail] K8sBandwidthTest Checks Bandwidth Rate-Limiting [It] Checks Pod to Pod bandwidth, geneve tunneling 
20:17:43  /home/jenkins/workspace/Cilium-PR-K8s-1.12-net-next/src/github.com/cilium/cilium/test/k8sT/Bandwidth.go:142

fristonio
fristonio requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the PR looks good to me. But I wonder with the changes in the PR we don't need any documentation related to hostscope IPAM as well?
Like removing - https://github.com/cilium/cilium/blob/master/Documentation/concepts/networking/ipam/hostscope.rst

christarazi
christarazi approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming everyone else's comments will be addressed.

@sayboras
Copy link
Member Author

sayboras commented Sep 3, 2020

The changes in the PR looks good to me. But I wonder with the changes in the PR we don't need any documentation related to hostscope IPAM as well?
Like removing - https://github.com/cilium/cilium/blob/master/Documentation/concepts/networking/ipam/hostscope.rst

Good catch, thanks a lot. Let me scan the docs one more time 🧐

@sayboras
Copy link
Member Author

sayboras commented Sep 4, 2020

Force pull for docs update, full CI is not required

git diff 
        deleted:    concepts/networking/ipam/hostscope.rst
        modified:   concepts/networking/ipam/index.rst

diff --git a/Documentation/concepts/networking/ipam/index.rst b/Documentation/concepts/networking/ipam/index.rst
index 32d770231..4bb72e55a 100644
--- a/Documentation/concepts/networking/ipam/index.rst
+++ b/Documentation/concepts/networking/ipam/index.rst
@@ -24,5 +24,4 @@ Cilium. Various IPAM modes are supported to meet the needs of different users:
    eni
    gke
    crd
-   hostscope
    deep_dive

fristonio
fristonio approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sayboras sayboras added the kind/cleanup This includes no functional changes. label Sep 4, 2020
@sayboras
cleanup/ipam: Remove hostscope-legacy IPAM option
00ba9f0 
To remove hostscope-legacy IPAM option

Fixes: cilium#12974

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras
Copy link
Member Author

sayboras commented Sep 5, 2020

test-me-please

@aanm aanm merged commit 175bd96 into cilium:master Sep 7, 2020
@sayboras sayboras deleted the cleanup/hostscope-legacy branch September 7, 2020 09:20
@qmonnet qmonnet mentioned this pull request Oct 8, 2020
Merged
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@fristonio fristonio fristonio approved these changes

@joestringer joestringer Awaiting requested review from joestringer

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up hostscope-legacy ipam option
5 participants
@sayboras @aanm @joestringer @christarazi @fristonio