egressgateway: Allow several CENPs with same egress IP #17773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Commit a783f7c ("k8s/cilium Event handlers and processing logic for egress nat policy"), having several CENPs with the same egress IP was explicitly disallowed. As explained in [1], the rationale was that those egress IPs are sometimes associated with security identities in external applications. However, this limitation is also preventing legitimate use cases. Users who would like to prevent this can implement it on top of Cilium. This commit removes the restriction. 1 - cilium#17678 Fixes: a783f7c ("k8s/cilium Event handlers and processing logic for egress nat policy") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug
|
/test |
jibi
approved these changes
Nov 4, 2021
|
Tests are passing. Janitor review was only required because of missing CODEOWNER (fixed in #17774). Marking ready to merge. |
pchaigno
added
the
ready-to-merge
nathanjsweet
approved these changes
Nov 4, 2021
|
Thanks @nathanjsweet to make the change. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit a783f7c ("k8s/cilium Event handlers and processing logic for egress nat policy"), having several CENPs with the same egress IP was explicitly disallowed. As explained in #17678, the rationale was that those egress IPs are sometimes associated with security identities in external applications. However, this limitation is also preventing legitimate use cases. Users who would like to prevent this can implement it on top of Cilium.
This pull request removes the restriction.
Fixes: #15134.
Fixes: #17678.