docs: Clarify use of the eni.subnetTagsFilter option
#19276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
area/documentation
gandro
requested review from
nathanjsweet,
kaworu,
aanm,
christarazi and
qmonnet
The `eni.subnetTagsFilter` option is notoriously hard to use correctly. If it is used with tags that don't match the subnet of the pre-attached ENI, Cilium agent will never become ready (cilium#18239). This PR removes it from the ENI documentation (which most users will use as a reference configuration) such that no one enables this option without being aware of its requirements. This PR also adds additional context the Helm value. We might deprecate and remove the option in the future as well (cilium#19181). Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/update-eni-docs
branch
from
0ac299f
to
d2bf3c2
Compare
christarazi
approved these changes
Mar 30, 2022
aanm
approved these changes
Mar 30, 2022
kaworu
approved these changes
Mar 31, 2022
nathanjsweet
approved these changes
Mar 31, 2022
borkmann
added
the
ready-to-merge
prune998
approved these changes
Apr 1, 2022
nbusseneau
added
backport-done/1.10
backport-done/1.11
|
Thanks for the heads up. I'll do a manual backport, thanks.
|
|
Oh, I confused some PRs here. Looking at the current v1.9 branch, yeah I agree that the backport is not needed. Sorry for the noise 🙇♂️ |
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eni.subnetTagsFilteroption is notoriously hard to use correctly.If it is used with tags that don't match the subnet of the pre-attached
ENI, Cilium agent will never become ready (#18239).
This PR removes it from the ENI documentation (which most users will use
as a reference configuration) such that no one enables this option
without being aware of its requirements. This PR also adds additional
context the Helm value. We might deprecate and remove the option in the
future as well (#19181).
Signed-off-by: Sebastian Wicki sebastian@isovalent.com