Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional print columns for ciliumnodes #21258

Merged
merged 1 commit into from
Sep 12, 2022
Merged

additional print columns for ciliumnodes #21258

merged 1 commit into from
Sep 12, 2022

Conversation

bavarianbidi
Copy link
Contributor

@bavarianbidi bavarianbidi commented Sep 9, 2022

add details about the InternalIP and CiliumInternalIP to the print columns when running kubectl get ciliumnode

NAME                                CILIUMINTERNALIP   INTERNALIP   AGE
control-plane-9e2fc530-2wgbj        10.0.5.141         10.6.0.105   22d
control-plane-9e2fc530-8nv4n        10.0.4.246         10.6.0.76    22d
control-plane-9e2fc530-gc47f        10.0.0.148         10.6.0.171   22d
worker-node-2ef62be2-dxjp9          10.0.3.42          10.6.0.221   27d
worker-node-2ef62be2-jldhp          10.0.1.60          10.6.0.156   27d
worker-node-2ef62be2-xpfc2          10.0.2.253         10.6.0.153   27d

Signed-off-by: Mario Constanti mario@constanti.de

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

Add the additional print columns `CiliumInternalIP` and `InternalIP` for `kubectl get ciliumnode` command.

@bavarianbidi bavarianbidi requested review from a team as code owners September 9, 2022 07:01
@bavarianbidi bavarianbidi requested a review from rolinh September 9, 2022 07:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 9, 2022
@bavarianbidi bavarianbidi requested a review from squeed September 9, 2022 07:01
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, can you update this version to 1.26.1? Thank you

@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 9, 2022
add details about the InternalIP and CiliumInternalIP to the print
columns when running kubectl get ciliumnode

Signed-off-by: Mario Constanti <mario@constanti.de>
@bavarianbidi bavarianbidi requested review from aanm and removed request for squeed and rolinh September 12, 2022 04:15
@aanm
Copy link
Member

aanm commented Sep 12, 2022

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 12, 2022
@nebril nebril merged commit 30b6978 into cilium:master Sep 12, 2022
@squeed
Copy link
Contributor

squeed commented Sep 12, 2022

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants