Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Agent Should Not Hard Fail on Config Values Above Max #22129

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

vishal-chdhry
Copy link
Contributor

@vishal-chdhry vishal-chdhry commented Nov 12, 2022

Signed-off-by: Vishal Choudhary contactvishaltech@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

When the amount of policy map entries exceeds PolicyMap max entries, instead of a hard exit with code 1, it throws a warning and enforces the hard maximum value.

Fixes: #22070

Automatically adjust `bpf-policy-map-max` if the maximum value is exceeded

Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
@vishal-chdhry vishal-chdhry requested review from a team as code owners November 12, 2022 14:17
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 12, 2022
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. cc @bmcustodio for visibility (iirc you had some thoughts on this as well)

@gandro
Copy link
Member

gandro commented Nov 14, 2022

Could you also add some more descriptive release note (either by changing the PR title or by adding a release notes section to your PR description)? For example:

Automatically adjust `bpf-policy-map-max` if the maximum value is exceeded

@gandro gandro added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 14, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 14, 2022
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself LGTM. Should we change the behavior for other map size values as well?

@tklauser tklauser merged commit 633cc5d into cilium:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent Should Not Hard Fail on Config Values Above Max
3 participants