Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable WireGuard in ci-multicluster again #23045

Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented Jan 11, 2023

Seems to be failing pretty consistently since we reenabled it in #22815. Let's disable it again and investigate.

Seems to be failing pretty consistently since we reenabled it in cilium#22815.
Let's disable it again and investigate.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added the release-note/ci This PR makes changes to the CI. label Jan 11, 2023
@gandro gandro requested review from a team as code owners January 11, 2023 15:49
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's check ci-clustermesh's result to see if it is because of WireGuard or not.

@gandro
Copy link
Member Author

gandro commented Jan 11, 2023

LGTM, let's check ci-clustermesh's result to see if it is because of WireGuard or not.

So this PR does not change the event trigger, so it's still going to use the CI workflow file from master. But checking recent failures of the workflow, the vast majority of them all failed in the WireGuard step (which was re-enabled mere 20 hours ago):

https://github.com/cilium/cilium/actions/workflows/conformance-multicluster.yaml?query=is%3Afailure

All of them struggle with DNS connectivity. Therefore I propose we merge this PR as is. We have enough sysdumps to investigate the WireGuard-specific issue. If disabling WireGuard doesn't help, we can investigate further.

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants