envoy: Fix lock leak in config validation failure #23077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If XDS listener configuration validation failed, addListener() would not unlock the XDSServer.mutex, leading to the lock being locked forever. Fix it by using a standard defer() approach. CC: Jarno Rajahalme <jarno@isovalent.com> Fixes: 1042b81 ("envoy: Add xDS resource validation") Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
needs-backport/1.12
release-note/bug
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
Travis hit #23079 . |
|
/test |
sayboras
approved these changes
Jan 12, 2023
|
ci-multicluster hit #21655, but this is not required in order to merge. |
ldelossa
added
backport-done/1.13
michi-covalent
added
backport-done/1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If XDS listener configuration validation failed, addListener() would not
unlock the XDSServer.mutex, leading to the lock being locked forever.
Fix it by using a standard defer() approach.
Fixes: 1042b81 ("envoy: Add xDS resource validation")