New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent: install CNI plugin binary in an InitContainer #24075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
reviewed
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it! One comment regarding Helm
gandro
approved these changes
Mar 1, 2023
|
/test |
aanm
approved these changes
Mar 10, 2023
This reduces the potential security surface of the agent by removing the bind-mount of /opt/cni/bin. Instead, write the binaries once in an initContainer. There is no currently known vulnerability exploiting this, but it's good practice to remove as many long-running host mounts as possible. This could be a potential further exploit vector if an agent were to be compromized. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
3631405
to
2a5abf7
Compare
|
/test |
|
/test-1.24-5.4 |
This was referenced Mar 11, 2023
|
It looks a little bit like this may have broken container initialization on master. EDIT: This may be just caused by unrebased PRs, sorry for the noise. |
This was referenced Mar 14, 2023
This was referenced Mar 21, 2023
4 tasks
anthonyhaussman
added a commit
to anthonyhaussman/kops
that referenced
this pull request
Apr 20, 2023
Starting cilium version `1.12.8` and to reduces the potential security surface of the agent, Cilium removes the bind-mount of `/opt/cni/bin` into the template. Instead, write the binaries once in an initContainer. Ref: - cilium/cilium#24075
anthonyhaussman
added a commit
to anthonyhaussman/kops
that referenced
this pull request
Apr 20, 2023
Starting cilium version `1.12.8` and to reduces the potential security surface of the agent, Cilium removes the bind-mount of `/opt/cni/bin` into the template. Instead, write the binaries once in an initContainer. Ref: - cilium/cilium#24075
anthonyhaussman
added a commit
to backmarket-oss/kops
that referenced
this pull request
Apr 20, 2023
Starting cilium version `1.12.8` and to reduces the potential security surface of the agent, Cilium removes the bind-mount of `/opt/cni/bin` into the template. Instead, write the binaries once in an initContainer. Ref: - cilium/cilium#24075
anthonyhaussman
added a commit
to backmarket-oss/kops
that referenced
this pull request
Apr 20, 2023
Starting cilium version `1.12.8` and to reduces the potential security surface of the agent, Cilium removes the bind-mount of `/opt/cni/bin` into the template. Instead, write the binaries once in an initContainer. Ref: - cilium/cilium#24075
anthonyhaussman
added a commit
to backmarket-oss/kops
that referenced
this pull request
Apr 20, 2023
Starting cilium version `1.12.8` and to reduces the potential security surface of the agent, Cilium removes the bind-mount of `/opt/cni/bin` into the template. Instead, write the binaries once in an initContainer. Ref: - cilium/cilium#24075
anthonyhaussman
added a commit
to anthonyhaussman/kops
that referenced
this pull request
Apr 24, 2023
Starting cilium version `1.12.8` and to reduces the potential security surface of the agent, Cilium removes the bind-mount of `/opt/cni/bin` into the template. Instead, write the binaries once in an initContainer. Ref: - cilium/cilium#24075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects/v1.10
This issue affects v1.10 branch
area/cni
Impacts the Container Networking Interface between Cilium and the orchestrator.
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reduces the potential security surface of the agent by removing the bind-mount of
/opt/cni/bin. Instead, write the binaries once in an initContainer.There is no currently known vulnerability exploiting this, but it's good practice to remove as many long-running host mounts as possible. This could be a potential further exploit vector if an agent were to be compromised.