Fix LookupReservedIdentityByLabels function to return consistent results

[skmatti]

Please ensure your pull request adheres to the following guidelines:

• For first time contributors, read Submitting a pull request
• All code is covered by unit and/or runtime tests where feasible.
• All commits contain a well written commit description including a title,
  description and a Fixes: #XXX line if the commit addresses a particular
  GitHub issue.
• If your commit description contains a Fixes: <commit-id> tag, then
  please add the commit author[s] as reviewer[s] to this issue.
• All commits are signed off. See the section Developer’s Certificate of Origin
• Provide a title or release-note blurb suitable for the release notes.
• Are you a user of Cilium? Please add yourself to the Users doc
• Thanks for contributing!

The function results inconsistent results if both fixed and reserved identities are present.

For e.g., the following returns 1

- "reserved:host"
- "k8s:io.cilium.fixed-identity=128"

whereas the following returns 128

- "k8s:io.cilium.fixed-identity=128"
- "reserved:host"

Also, this simplifies the logic to make it more readable.

[maintainer-s-little-helper]

Commit 287605c5d18e35c860405e517075a1fa85a64235 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 287605c5d18e35c860405e517075a1fa85a64235 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commits ab86fcf4d6568446162660c38fd6e79d0374acce, c315ca586c1c2233d28aeed9946249a95bf5831a do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commits ab86fcf4d6568446162660c38fd6e79d0374acce, c315ca586c1c2233d28aeed9946249a95bf5831a do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit ab86fcf4d6568446162660c38fd6e79d0374acce does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 3686ef81ed11f2fa8679c6b554a46cfed37ab41d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit bd89c81eb22f62e9913d43c3802dc0f3cd03505c does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit bd89c81eb22f62e9913d43c3802dc0f3cd03505c does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[aditighag]

Thanks for your contribution. Could you go over the guidelines to submit a PR - https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#submitting-a-pull-request? More specifically, the change-id in the sign-off can be dropped from the commit message. Is this a user facing commit? We'll need to add a label accordingly.
In the meantime, I've triggered the tests.

[skmatti]

Thanks for your contribution. Could you go over the guidelines to submit a PR - https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#submitting-a-pull-request? More specifically, the change-id in the sign-off can be dropped from the commit message. Is this a user facing commit? We'll need to add a label accordingly. In the meantime, I've triggered the tests.

Thanks for your comment, I just updated the comment.

[nathanjsweet]

/test

[nathanjsweet]

This is much better. Thank you for reworking this logic!

[nathanjsweet]

Thanks @skmatti 🙏 !

[joestringer]

heads up @ldelossa I switched this to release-note/misc since it wasn't obvious to me whether there was any user-facing observable change here. If there is a workflow where we think that this could impact users, then feel free to switch the release-note back. It may then also be helpful to describe how they may be impacted and consider even whether there should be an upgrade note to describe the impact.