Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove proxylib limitation in observability section #27306

Merged
merged 1 commit into from
Aug 8, 2023
Merged

docs: Remove proxylib limitation in observability section #27306

merged 1 commit into from
Aug 8, 2023

Conversation

darkrift
Copy link
Contributor

@darkrift darkrift commented Aug 6, 2023 •
edited
Loading

This removes the proxylib limitation from the observability documentation that seems to now be fixed according to the last few messages in #14072

@darkrift darkrift requested review from a team as code owners August 6, 2023 18:57
@darkrift darkrift requested review from nebril and lambdanis August 6, 2023 18:57
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 6, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 6, 2023
lambdanis
lambdanis approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, just in time, the issue seems fixed for a year. Thank you!

@lambdanis lambdanis added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 7, 2023
@lambdanis
Copy link
Contributor

/test

@sayboras sayboras changed the title Remove proxylib limitation in observability documentation docs: Remove proxylib limitation in observability section Aug 7, 2023
@sayboras sayboras added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Aug 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 7, 2023
@nebril
Copy link
Member

nebril commented Aug 7, 2023

This should also be in 1.14 docs, right? Will mark for backport.

@nebril nebril added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 7, 2023
@ldelossa
Copy link
Contributor

ldelossa commented Aug 7, 2023

@lambdanis your commit message is making checkpatch fail:

  Error: ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 86)

Please fix this so BPF checks / checkpatch (pull_request) does not fail.

@ldelossa ldelossa removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 7, 2023
@lambdanis
Copy link
Contributor

@darkrift Can you please reword the commit message to make the title shorter and fix the checkpath fail

@darkrift
Remove proxylib limitation
1d0f7cf 
Signed-off-by: Richard Lavoie <lavoie.richard@gmail.com>
@darkrift darkrift force-pushed the remove_proxylib_limitation_in_observability branch from 9b5eca6 to 1d0f7cf Compare August 7, 2023 20:15
@darkrift
Copy link
Contributor Author

darkrift commented Aug 7, 2023

@lambdanis @ldelossa Should be good now.

Do I need to make the backport or is that going to be picked up automatically or by someone else?

@lambdanis
Copy link
Contributor

@darkrift Thanks! The backport will be done by someone as a part of regular process.

@ldelossa ldelossa merged commit cd80d2c into cilium:main Aug 8, 2023
@tklauser tklauser mentioned this pull request Aug 22, 2023
Merged
22 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 22, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdanis lambdanis lambdanis approved these changes

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.14.2
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darkrift @lambdanis @nebril @ldelossa @tklauser @joestringer @sayboras