Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source and destination workload_kind context labels (Hubble). #27350

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Add source and destination workload_kind context labels (Hubble). #27350

merged 1 commit into from
Aug 16, 2023

Conversation

marqc
Copy link
Contributor

@marqc marqc commented Aug 8, 2023

Please ensure your pull request adheres to the following guidelines:

  • All code is covered by unit and/or runtime tests where feasible.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Add source and destination workload_kind context labels (Hubble).

Add source and destination workload_kind context labels (Hubble).

recreated #25715 because of CI issues @ldelossa

@marqc @zacharysarah
Add source and destination workload_kind context labels (Hubble).
80b89f6 
Co-authored-by: ZSC <zacharysarah@users.noreply.github.com>
Signed-off-by: Marek Chodor <mchodor@google.com>
@marqc marqc requested review from a team as code owners August 8, 2023 14:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 8, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 8, 2023
zacharysarah
zacharysarah approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@tklauser tklauser added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay labels Aug 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 9, 2023
lambdanis
lambdanis approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tklauser
Copy link
Member

/test

@kaworu kaworu requested a review from chancez August 10, 2023 13:40
@ti-mo
Copy link
Contributor

ti-mo commented Aug 16, 2023 •
edited

Let's just merge this, not sure why Travis isn't running for you. @marqc Did you upset him by any chance? 😉

@ti-mo ti-mo merged commit 8bb8a77 into cilium:main Aug 16, 2023
59 checks passed
@marqc marqc mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@chancez chancez chancez approved these changes

@nebril nebril nebril approved these changes

@lambdanis lambdanis lambdanis approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@marqc @tklauser @ti-mo @chancez @nebril @lambdanis @zacharysarah