-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source and destination workload_kind context labels (Hubble). #27350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ZSC <zacharysarah@users.noreply.github.com> Signed-off-by: Marek Chodor <mchodor@google.com>
zacharysarah
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for docs
tklauser
approved these changes
Aug 9, 2023
lambdanis
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/test |
nebril
approved these changes
Aug 10, 2023
chancez
approved these changes
Aug 10, 2023
Let's just merge this, not sure why Travis isn't running for you. @marqc Did you upset him by any chance? 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/community-contribution
This was a contribution made by a community member.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
sig/hubble
Impacts hubble server or relay
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Add source and destination workload_kind context labels (Hubble).
recreated #25715 because of CI issues @ldelossa