-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpv1: Adds CiliumPodIPPool Support to PathAttr Policies #28310
Conversation
@rastislavs I marked this PR as a draft b/c I am not seeing the path attributes being added for prefixes being advertised from a CiliumPodIPPool. I temporarily added logging throughout for troubleshooting but I'm unable to root cause the issue. When you have time, can you take a look? Test resources:
|
Thanks for the PR! I think the reason why this is not working ATM is in this comment: https://github.com/cilium/cilium/pull/28310/files#r1339661669 FYI, I plan to add a CLI command for listing the routing policies, so that similar issues are easier to debug in the future. |
41dda91
to
b9cf743
Compare
b9cf743
to
2085898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
/test |
1 similar comment
@harsimran-pabla when you have a moment, do you mind doing another review? |
/test |
/ci-l4lb |
Commit 301fa26 is a rebase to see if it fixes the |
/test |
@rastislavs @harsimran-pabla @YutaroHayakawa This PR is passing CI. Do you have suggestions on how to get this merged? |
Seems like we still need a review from @youngnick. Once his review is in, you can put the tag |
@youngnick This PR has been hanging around for a few weeks. Do you mind reviewing when you have a moment or can you assign another reviewer? |
@christarazi anyone else from sig-k8s you recommend to unblock this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The K8s changes LGTM to me. Could you add justification in the commit msg? Without it, we lose potentially important context in git history if later down the line we bisect this commit.
@christarazi thanks for the review. I have updated the commit message to include additional change details and the fixed issue. |
/test |
- Adds the CiliumPodIPPool selector type to BGP CP CiliumBGPPathAttributes API. - Updates RoutePolicyReconciler to support CiliumPodIPPool. - Added unit tests for the CiliumPodIPPool selector type. - Regenerated CiliumBGPPeeringPolicy CRD. Fixes: cilium#28296 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
99019dc
to
60f55e2
Compare
Commit 60f55e2 rebases to fix CI flakes. |
/test |
Fixes: #28296