ingress: Propagate labels from Ingress to LB Service

[log1cb0mb]

This PR adds the labels from Ingress to Load Balancer Service.

Fixes: #28576

Propagate prefixed labels from Ingress resource to LB service

[youngnick]

Thanks for your contribution @log1cb0mb.

I have complicated feelings about this one. In general, I'm not in favor of copying labels or annotations around - I think it's a pretty dirty hack to fit config that should really be stored in a structured field somewhere into labels. But, because we don't have any way to set the settings we want to on the generated Service object, we're kinda stuck with it.

Additionally, we've tried to make this a little more specific with annotations - do you think that we could use a similar mechanism for labels and only copy labels that start with certain strings? I haven't looked at the labels in use for configuring things on Service for some time.

If we agree we want to blindly copy everything, though, the code change itself is fine, but I'd like to see a couple of extra things please?

Firstly, can you update the docs page in Documentation/network/servicemesh/ingress.rst with some information about how all labels will now be copied in addition to annotations?

Secondly, if you could have a look at the tests and see if you can make a test that checks that everything works as expected on the generated Service, that would be awesome. That's a non-blocking request though, so if you would like to merge this first, one of us can either work with you or pick it up to add it later.

So, tl;dr, three things:

• Can you talk a little about copying everything? Would it be okay to use the same logic as the annotations and only copy some labels?
• Please add some docs in the page I mentioned.
• Extra task if you can, but non-blocking, see if you can add some tests?

Thanks again for the contribution, @log1cb0mb, really great to see and well done!

[maintainer-s-little-helper]

Commit 0e865b5 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 11c08bd does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 11c08bd does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[aanm]

/test

[meyskens]

/test

[meyskens]

changes to ingress re LGTM

[aanm]

/test

[joamaki]

/test

[log1cb0mb]

Is it possible to add backport-1.14 label to this?

[log1cb0mb]

/test

[giorio94]

Closed and reopened to see if travis gets triggered, as it was stuck

[giorio94]

Reviews are in, and checks are green. Marking as ready to merge.