-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IPv6 cilium_host address assignment #28633
Conversation
This time against main and with better description I hope. I need somebody who uses tunelling to test this thoguh, we use eBGP with /120 per node and pod subnet being within the same /64. |
d405c9e
to
1207b4f
Compare
Nit: Could you change the commit message to something like:
That way we reference my commit that introduced the bug and explain that this happened when moving away from |
1207b4f
to
ee79717
Compare
Is it not auto-linking the bug commit because of the # in front of the SHA? I guess you only need that for issues 🤦 Sorry for being so nit picky here, but the whole idea of the proposed commit message was to be able to click through to the bad commit. |
Fixes cilium#28327 This patch fixes the subnet assigned to the cilium_host device from /64 back to /128, a bug introduced in ecd4fc0 when converting the init.sh script to Go code. The conversion never meant to change the behavior in init.sh and the bug caused connectivity issues in certain cilium configurations. Signed-off-by: Ashley Reese <ashley@victorianfox.com>
ee79717
to
12e83d0
Compare
better :) |
Thank you! 🙏 |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #28327
This patch stops adding /64 route to the cilium_net iface, which brought all the traffic to local node. When using something like /128 per node and having pods within the same /64 as the node meant that no cross-node traffic from pods worked.