-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor helm improvements concerning clustermesh #28763
Merged
aditighag
merged 2 commits into
cilium:main
from
giorio94:mio/clustermesh-helm-validation
Oct 30, 2023
Merged
Minor helm improvements concerning clustermesh #28763
aditighag
merged 2 commits into
cilium:main
from
giorio94:mio/clustermesh-helm-validation
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
giorio94
commented
Oct 24, 2023
- Add validation to explicit clustermesh-apiserver incompatibilities with Cilium running in kvstore mode
- Allow to create the clustermesh configuration also when clustermesh-apiserver is disabled
The clustermesh-apiserver cannot be used in combination with Cilium running in kvstore mode if either identity allocation is set to kvstore mode or the CiliumEndpoint CRD is disabled. In these cases, clustermesh can be enabled directly setting the parameters to access the local kvstore in the remote clustermesh configuration. Similarly, also external workloads support cannot be enabled in such configurations. Let's make these constraints more explicit by adding dedicated validation through Helm. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Modify the helm chart to create the cilium-clustermesh secret (i.e., the list of remote clusters to connect to) if the corresponding enable flag is set, independently of whether the clustermesh-apiserver is enabled or not. This allows using the same helm settings also in case Cilium is configured in kvstore mode, and agents can directly connect to the remote etcd clusters. In this case, it is users' responsibility to specify the appropriate key, certificate and certificate authority for each remote etcd cluster. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
/test |
squeed
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: nevermind, mis-read the PR
squeed
approved these changes
Oct 25, 2023
thorn3r
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 1-up for UX
joamaki
approved these changes
Oct 30, 2023
Closed
3 tasks
giorio94
added a commit
to giorio94/cilium-cli
that referenced
this pull request
May 10, 2024
cilium/cilium#28763 decoupled the helm settings to enable the clustermesh-apiserver and provide the list of clusters to connect to. Let's reflect this change to the 'cilium clustermesh disable' command as well, explicitly disabling and resetting the remote clusters configs when invoked, to correctly disconnect from possible leftover clusters. Fixes: cilium/cilium#32300 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
michi-covalent
pushed a commit
to cilium/cilium-cli
that referenced
this pull request
May 15, 2024
cilium/cilium#28763 decoupled the helm settings to enable the clustermesh-apiserver and provide the list of clusters to connect to. Let's reflect this change to the 'cilium clustermesh disable' command as well, explicitly disabling and resetting the remote clusters configs when invoked, to correctly disconnect from possible leftover clusters. Fixes: cilium/cilium#32300 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
michi-covalent
pushed a commit
that referenced
this pull request
Jul 16, 2024
#28763 decoupled the helm settings to enable the clustermesh-apiserver and provide the list of clusters to connect to. Let's reflect this change to the 'cilium clustermesh disable' command as well, explicitly disabling and resetting the remote clusters configs when invoked, to correctly disconnect from possible leftover clusters. Fixes: #32300 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
michi-covalent
pushed a commit
that referenced
this pull request
Aug 5, 2024
[ cherry-picked from cilium/cilium-cli repository ] #28763 decoupled the helm settings to enable the clustermesh-apiserver and provide the list of clusters to connect to. Let's reflect this change to the 'cilium clustermesh disable' command as well, explicitly disabling and resetting the remote clusters configs when invoked, to correctly disconnect from possible leftover clusters. Fixes: #32300 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
[ cherry-picked from cilium/cilium-cli repository ] #28763 decoupled the helm settings to enable the clustermesh-apiserver and provide the list of clusters to connect to. Let's reflect this change to the 'cilium clustermesh disable' command as well, explicitly disabling and resetting the remote clusters configs when invoked, to correctly disconnect from possible leftover clusters. Fixes: #32300 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
area/helm
Impacts helm charts and user deployment experience
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.