-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config option to set the default IP Pool #28818
Conversation
a34e15a
to
c90d883
Compare
Requested a review from @gandro given he is currently working on addressing some tech-debt in the multi-pool IPAM code and this might conflict with his work. |
Nice improvement, changes generally make sense to me @gandro Should this have some sort of validation that the pools in question exist? |
c90d883
to
d6b1637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work! Looks excellent to me overall. I've left some feedback regarding the pre-allocation
d6b1637
to
78406f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the update! One last minor nit
78406f0
to
e077b12
Compare
e077b12
to
afb2c31
Compare
/test |
This is a GitHub error. |
It seems GitHub is having troubles. Let me close and re-open the PR, that should re-trigger the workflows. |
Test image build may have failed causing a bunch of cascading test failures. Iet's retry. |
/test |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only some small spelling nits.
Config option to customize the default IP Pool when using MultiPool Fixes: cilium#27131 Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
afb2c31
to
1b846f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Config option to customize the default IP Pool when using MultiPool
Fixes: #27131
Please ensure your pull request adheres to the following guidelines:
Fixes: #issue-number