Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipset: ignore not found errors on entry removal #29561

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Dec 1, 2023

Configure the extra flag to prevent the ipset command from returning an error if the entry that we are trying to remove is already not present. This change brings consistency with the add command (which already sets the same flag), and enables us to attempt to remove an entry even if it may not exist, e.g., to cleanup possible stale entries.

Fixes: #issue-number

Don't log an error if the to be deleted ipset entry does not exist

Configure the extra flag to prevent the ipset command from returning an
error if the entry that we are trying to remove is already not present.
This change brings consistency with the add command (which already sets
the same flag), and enables us to attempt to remove an entry even if
it may not exist, e.g., to cleanup possible stale entries.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Dec 1, 2023
@giorio94 giorio94 requested a review from a team as a code owner December 1, 2023 17:41
@giorio94
Copy link
Member Author

giorio94 commented Dec 1, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 4, 2023
@borkmann borkmann added this pull request to the merge queue Dec 4, 2023
Merged via the queue into cilium:main with commit 95d7c88 Dec 4, 2023
62 checks passed
@giorio94 giorio94 deleted the mio/ipset-del-not-exists branch December 4, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants