Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add MaxConnectedClusters documentation #29637

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

thorn3r
Copy link
Contributor

@thorn3r thorn3r commented Dec 5, 2023

Adds a section to the ClusterMesh guide describing how to increase the limit of connected clusters using the MaxConnectedClusters option. Since there is no migration path for existing Cilium installations, a warning at the end of the section calls out that this should not be changed post-installation.

@thorn3r thorn3r requested review from a team as code owners December 5, 2023 16:08
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 5, 2023
@thorn3r thorn3r added the release-note/misc This PR makes changes that have no direct user impact. label Dec 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 5, 2023
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thorn3r! I've left a couple of suggestions inline.

Documentation/network/clustermesh/clustermesh.rst Outdated Show resolved Hide resolved
Documentation/network/clustermesh/clustermesh.rst Outdated Show resolved Hide resolved
Documentation/network/clustermesh/clustermesh.rst Outdated Show resolved Hide resolved
@giorio94 giorio94 added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/clustermesh Relates to multi-cluster routing functionality in Cilium. labels Dec 6, 2023
Adds a section to the ClusterMesh guide describing how to increase the
limit of connected clusters using the `MaxConnectedClusters` option.
Since there is no migration path for existing Cilium installations, a
warning at the end of the section calls out that this should not be
changed post-installation.

Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
@thorn3r
Copy link
Contributor Author

thorn3r commented Dec 6, 2023

Thanks @giorio94! Updated with your suggestions, lmk what you think

@thorn3r thorn3r requested a review from giorio94 December 6, 2023 21:09
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@giorio94
Copy link
Member

giorio94 commented Dec 7, 2023

/test

@aanm aanm added this pull request to the merge queue Dec 7, 2023
Merged via the queue into cilium:main with commit de7aa98 Dec 7, 2023
58 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants