complexity-tests: fix copying verifier log output to artifacts #29752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the following find command is subtle:
find . -name foo -o -name bar -exec ...
This means: execute the command for bar. It doesn't execute the command for foo.
For this reason verifier logs are currently not being copied correctly into
GH artifacts.
Fixes: 735807f ("test/verifier: fix complexity tests not being recompiled")
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
added
sig/loader
|
/ci-verifier |
|
/test |
markpash
approved these changes
Dec 11, 2023
viktor-kurchenko
approved these changes
Dec 11, 2023
|
/ci-ipsec-upgrade |
|
/ci-awscni |
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
gentoo-root
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the following find command is subtle:
This means: execute the command for bar. It doesn't execute the command for foo. For this reason verifier logs are currently not being copied correctly into GH artifacts.
Fixes: 735807f ("test/verifier: fix complexity tests not being recompiled")