Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update go to v1.21.6 (v1.13) (minor) #29817

Merged
merged 3 commits into from
Jan 31, 2024
Merged

chore(deps): update go to v1.21.6 (v1.13) (minor) #29817

merged 3 commits into from
Jan 31, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 12, 2023 •
edited

Mend Renovate

This PR contains the following updates:

Package Type Update Change
docker.io/library/golang stage minor 1.20.13 -> 1.21.6
docker.io/library/golang final minor 1.20.13 -> 1.21.6
go (source) minor 1.19.13 -> 1.21.6
go (source) minor 1.20.13 -> 1.21.6

Release Notes

golang/go (go)

v1.21.6

v1.21.5

v1.21.4

v1.21.3

v1.21.2

v1.21.1

v1.21.0

v1.20.13

v1.20.12

v1.20.11

v1.20.10

v1.20.9

v1.20.8

v1.20.7

v1.20.6

v1.20.5

v1.20.4

v1.20.3

v1.20.2

v1.20.1

v1.20.0

Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners December 12, 2023 12:30
@renovate renovate bot added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. renovate/stop-updating Tell Renovate to stop updating PR labels Dec 12, 2023
@renovate renovate bot requested a review from brlbil December 12, 2023 12:30
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Dec 12, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 12, 2023
@tklauser
Copy link
Member

Go lint workflow failures should be fixed by #29818

@tklauser
Copy link
Member

Go lint workflow failures should be fixed by #29818

Triggered a rebase to get the fix in #29818.

@renovate renovate bot changed the title chore(deps): update dependency go to v1.20.12 (v1.13) chore(deps): update go (v1.13) Dec 13, 2023
@renovate renovate bot requested a review from a team as a code owner December 15, 2023 14:20
@renovate renovate bot requested a review from glibsm December 15, 2023 14:20
@renovate renovate bot changed the title chore(deps): update go (v1.13) chore(deps): update go to v1.21.6 (v1.13) (minor) Jan 11, 2024
@renovate renovate bot temporarily deployed to release-base-images January 11, 2024 15:45 Inactive
@aanm
Copy link
Member

aanm commented Jan 26, 2024

/test-1.21-4.19

@aanm
Copy link
Member

aanm commented Jan 26, 2024

@tklauser it looks that all tests have passed except the linter https://github.com/cilium/cilium/actions/runs/7655898083/job/20895181946?pr=29817 😢

@tklauser
Copy link
Member

@tklauser it looks that all tests have passed except the linter https://github.com/cilium/cilium/actions/runs/7655898083/job/20895181946?pr=29817 😢

Looks like on v1.13 we're using a version of golangci-lint not compatible with Go 1.21. I've pushed an additional commit bumping golangci-lint to v1.55.2 (as on main).

@tklauser
Copy link
Member

tklauser commented Jan 30, 2024 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:30216 failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.19/428/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Job 'Cilium-PR-K8s-1.21-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig MonitorAggregation Checks that monitor aggregation restricts notifications

Failure Output

FAIL: Error creating resource /home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.19/src/github.com/cilium/cilium/test/k8s/manifests/l3-policy-demo.yaml: Cannot retrieve cilium pod cilium-l7tdb policy revision: cannot get the revision

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/376/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

tklauser and others added 3 commits January 30, 2024 13:30
@tklauser
ci: update golangci-lint to a version compatible with Go 1.21
4ee10f9 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@renovate @tklauser
chore(deps): update go to v1.21.6
f6d4b1a 
Signed-off-by: renovate[bot] <bot@renovateapp.com>
@tklauser
images: update cilium-{runtime,builder}
99281f7 
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
@tklauser tklauser temporarily deployed to release-base-images January 30, 2024 12:30 — with GitHub Actions Inactive
@tklauser
Copy link
Member

tklauser commented Jan 30, 2024 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.21-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig MonitorAggregation Checks that monitor aggregation restricts notifications

Failure Output

FAIL: Error creating resource /home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.19/src/github.com/cilium/cilium/test/k8s/manifests/l3-policy-demo.yaml: Cannot retrieve cilium pod cilium-7mr6b policy revision: cannot get the revision

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/378/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@tklauser
Copy link
Member

/ci-l4lb

@tklauser
Copy link
Member

/test-backport-1.13

For some reason this didn't trigger the GHA workflows, maybe a temporary GitHub glitch? Triggering them manually works, so I'll do that.

@tklauser
Copy link
Member

/ci-clustermesh

@tklauser
Copy link
Member

/ci-awscni

@tklauser
Copy link
Member

/ci-e2e

@tklauser
Copy link
Member

/ci-ingress

@tklauser
Copy link
Member

/ci-ipsec-e2e

@tklauser
Copy link
Member

/ci-gke

@tklauser
Copy link
Member

/ci-external-workloads

@tklauser
Copy link
Member

/ci-gateway-api

@tklauser
Copy link
Member

/ci-eks

@tklauser tklauser removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jan 30, 2024
@tklauser
Copy link
Member

/test-1.21-4.19

julianwiedmann
julianwiedmann approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @tklauser, ty!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 31, 2024
@julianwiedmann julianwiedmann merged commit 9fe247a into v1.13 Jan 31, 2024
196 of 204 checks passed
@julianwiedmann julianwiedmann deleted the renovate/v1.13-go branch January 31, 2024 07:06
@michi-covalent michi-covalent mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glibsm glibsm glibsm approved these changes

@brlbil brlbil brlbil approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees

@tklauser tklauser

Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. renovate/stop-updating Tell Renovate to stop updating PR
Projects
No open projects
cilium v1.13.12
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tklauser @qmonnet @aanm @squeed @glibsm @brlbil @julianwiedmann