Simplify CI image build workflow before v1.15 branch #29834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the branching steps for stable branches when we create them. Co-authored-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
This commit extends the conditional logic for running this logic against the main branch, so that we can keep the steps in place on older branches without causing the cache to get thrashed by stable branch versions of the cache. This allows us to have fewer lines of diff between the main and older (eg v1.14) branches. Co-authored-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
requested review from
brlbil,
aanm,
michi-covalent and
nbusseneau
joestringer
force-pushed
the
pr/joe/workflow-gh-main
branch
from
c4b6078
to
23b6045
Compare
|
CI passed with Dropping the test commit. |
joestringer
force-pushed
the
pr/joe/workflow-gh-main
branch
from
23b6045
to
e218839
Compare
aanm
approved these changes
Dec 13, 2023
brlbil
approved these changes
Dec 13, 2023
nbusseneau
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files end up with massive diffs when trying to create a stable branch
from the main branch. With some minor care and attention, we can simplify the
steps to create a branch with identical workflows to the main branch.
See commits for more details: