statedb: Fix revision indexing #29840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
added
the
release-note/misc
Revision index was marked unique, but encoded the key as "<revision> <primary key>". This was an accidental leftover from when revision was per-transaction rather than per insert/delete. The key can now be simplified to just "<revision>". This issue combined with "statedb: Allow non-terminated keys" broke revision queries via the statedb REST API handler as the lowerbound iteration terminated when the key length did not match. Fix the REST API handler as well to not check result keys when doing lowerbound search. Fixes: aa15ba7 ("statedb: Allow non-terminated keys") Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/fix-revision-indexing
branch
from
57f44b7
to
73de5e7
Compare
|
/test |
joamaki
added
the
release-blocker/1.15
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision index was marked unique, but encoded the key as
<revision> <primary key>. This was an accidental leftover from when revision was per-transaction rather than per insert/delete. The key can now be simplified to just<revision>.This issue combined with "statedb: Allow non-terminated keys" broke revision queries via the statedb REST API handler as the lowerbound iteration terminated when the key length did not match. Fix the REST API handler as well to not check result keys when doing lowerbound search.
Fixes: aa15ba7 ("statedb: Allow non-terminated keys")