Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datapath, bpf: Remove unnecessary IPsec code #31344

Merged

Conversation

pchaigno
Copy link
Member

Commit 891fa78 ("bpf: Delete obsolete do_netdev_encrypt_pools()") removed the special code we had to rewrite the IPsec outer header. The code removed in the present commit is therefore not required anymore.

Fixes: #28063.

@pchaigno pchaigno added area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. feature/ipsec Relates to Cilium's IPsec feature labels Mar 12, 2024
@pchaigno pchaigno force-pushed the ipsec-cleanup-header-rewrite-leftovers branch from d1276f9 to e9170c4 Compare March 12, 2024 11:29
@pchaigno pchaigno added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Mar 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Mar 12, 2024
@pchaigno pchaigno force-pushed the ipsec-cleanup-header-rewrite-leftovers branch from e9170c4 to 238215f Compare March 12, 2024 18:07
@jrajahalme jrajahalme removed this from Needs backport from main in 1.15.2 Mar 13, 2024
@pchaigno pchaigno force-pushed the ipsec-cleanup-header-rewrite-leftovers branch from 238215f to ba6e5c4 Compare March 13, 2024 12:13
Commit 891fa78 ("bpf: Delete obsolete do_netdev_encrypt_pools()")
removed the special code we had to rewrite the IPsec outer header. The
code removed in the present commit is therefore not required anymore.

Fixes: 891fa78 ("bpf: Delete obsolete do_netdev_encrypt_pools()")
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the ipsec-cleanup-header-rewrite-leftovers branch from ba6e5c4 to d9ad77d Compare March 14, 2024 14:08
@pchaigno
Copy link
Member Author

/test

@pchaigno pchaigno marked this pull request as ready for review March 15, 2024 00:07
@pchaigno pchaigno requested a review from a team as a code owner March 15, 2024 00:07
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 15, 2024
Merged via the queue into cilium:main with commit 4ba7e6a Mar 15, 2024
62 checks passed
@pchaigno pchaigno deleted the ipsec-cleanup-header-rewrite-leftovers branch March 15, 2024 10:25
@gandro gandro mentioned this pull request Mar 19, 2024
21 tasks
@gandro gandro added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 19, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

4 participants