Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add table for which pkts are encrypted with WG #31557

Merged
merged 1 commit into from
Apr 29, 2024
Merged

docs: Add table for which pkts are encrypted with WG #31557

merged 1 commit into from
Apr 29, 2024

Conversation

brb
Copy link
Member

@brb brb commented Mar 22, 2024

Fix #24589

@brb brb added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. labels Mar 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 22, 2024
gandro
gandro reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks! In terms of correctness, this looks great to me! I've left a bit of feedback regarding the language though.

Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
@brb brb force-pushed the pr/brb/docs--wg-what-encrypted branch from 5915624 to 76bd925 Compare April 25, 2024 10:46
@brb
Copy link
Member Author

brb commented Apr 25, 2024

@gandro @julianwiedmann PTAL. I have updated the table with your suggestions + restructured it.

@brb brb added the release-note/misc This PR makes changes that have no direct user impact. label Apr 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 25, 2024
@brb brb marked this pull request as ready for review April 25, 2024 11:51
@brb brb requested review from a team as code owners April 25, 2024 11:51
@brb brb requested a review from qmonnet April 25, 2024 11:51
gandro
gandro approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! The new format is very understandable

Documentation/security/network/encryption-wireguard.rst Show resolved Hide resolved
@brb brb force-pushed the pr/brb/docs--wg-what-encrypted branch 5 times, most recently from bb4d766 to 8e8f313 Compare April 25, 2024 12:43
@julianwiedmann
Copy link
Member

julianwiedmann commented Apr 25, 2024 •
edited

How much effort do we want to spend for baking DSR-Geneve into this (#32180 (comment)) ? As long as XDP is disabled, I would expect all DSR-forwarded traffic to be encrypted by the LB node. Doesn't matter whether native/overlay routing, or whether the service backend is a pod / lives in hostns. It all gets wrapped in GENEVE, and thus to-netdev should pick it up.

@brb brb force-pushed the pr/brb/docs--wg-what-encrypted branch from 8e8f313 to 76361aa Compare April 25, 2024 14:17
@brb
Copy link
Member Author

brb commented Apr 25, 2024

@julianwiedmann Added Geneve + DSR.

julianwiedmann
julianwiedmann approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few wording nits, and adding hostNetwork backends for DSR-Geneve.

Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
@brb brb force-pushed the pr/brb/docs--wg-what-encrypted branch from 76361aa to 7f37975 Compare April 25, 2024 15:04
qmonnet
qmonnet requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've an issue with the last sentence, but the rest looks good, thanks!

Documentation/security/network/encryption-wireguard.rst Outdated Show resolved Hide resolved
@brb brb force-pushed the pr/brb/docs--wg-what-encrypted branch from 7f37975 to 94f8048 Compare April 29, 2024 14:00
@brb brb requested a review from qmonnet April 29, 2024 14:02
@brb
docs: Add table for which pkts are encrypted with WG
dde0a2d 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/docs--wg-what-encrypted branch from 94f8048 to dde0a2d Compare April 29, 2024 14:06
qmonnet
qmonnet approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@qmonnet
Copy link
Member

qmonnet commented Apr 29, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 29, 2024
@brb brb added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 57240c3 Apr 29, 2024
61 checks passed
@brb brb deleted the pr/brb/docs--wg-what-encrypted branch April 29, 2024 14:27
@julianwiedmann julianwiedmann added the feature/wireguard Relates to Cilium's Wireguard feature label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@qmonnet qmonnet qmonnet approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. feature/wireguard Relates to Cilium's Wireguard feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Document which flows are encrypted with WireGuard
4 participants
@brb @julianwiedmann @qmonnet @gandro