-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add table for which pkts are encrypted with WG #31557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks! In terms of correctness, this looks great to me! I've left a bit of feedback regarding the language though.
5915624
to
76bd925
Compare
@gandro @julianwiedmann PTAL. I have updated the table with your suggestions + restructured it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you! The new format is very understandable
bb4d766
to
8e8f313
Compare
How much effort do we want to spend for baking DSR-Geneve into this (#32180 (comment)) ? As long as XDP is disabled, I would expect all DSR-forwarded traffic to be encrypted by the LB node. Doesn't matter whether native/overlay routing, or whether the service backend is a pod / lives in hostns. It all gets wrapped in GENEVE, and thus |
8e8f313
to
76361aa
Compare
@julianwiedmann Added Geneve + DSR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few wording nits, and adding hostNetwork
backends for DSR-Geneve.
76361aa
to
7f37975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've an issue with the last sentence, but the rest looks good, thanks!
7f37975
to
94f8048
Compare
Signed-off-by: Martynas Pumputis <m@lambda.lt>
94f8048
to
dde0a2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/test |
Fix #24589