Miscellaneous improvements to the clustermesh upgrade/downgrade test #31958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
giorio94
commented
Apr 15, 2024
•
giorio94
commented
- Slow down agent rollout to better highlight possible issues;
- Hard-code IPAM mode and operator replicas to prevent changes due to defaulting;
- Fix incorrectly named test to ensure that it is actually executed;
- Do not wait for hubble relay images, as not deployed;
- Enable hubble and configure medium monitor aggregation, to simplify troubleshooting issues.
The goal being to slow down the rollout process, to better highlight possible connection disruption occurring in the meanwhile. At the same time, this also reduces the overall CPU load caused by datapath recompilation, which is a possible additional cause for connection disruption flakiness. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The default IPAM mode is cluster-pool, which gets automatically overwritten by the Cilium CLI to kubernetes when running on kind. However, the default helm value gets restored upon upgrade due to --reset-values, causing confusion and possible issues. Hence, let's explicitly configure it to kubernetes, to prevent changes. Similarly, let's configure a single replica for the operator. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
So that it gets actually executed. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
area/CI
|
/test |
viktor-kurchenko
approved these changes
Apr 15, 2024
Hubble relay is not deployed in this workflow, hence it doesn't make sense to wait for the image availability. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
As it simplifies troubleshooting possible connection disruptions. However, let's configure monitor aggregation to medium (i.e., the maximum, and default value) to avoid the performance penalty due to the relatively high traffic load. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
|
Sorry @viktor-kurchenko, I've pushed a couple of additional minor changes. Could you please take another look? |
YutaroHayakawa
approved these changes
Apr 17, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
lmb
deleted the
pr/giorio94/main/gha-clustermesh-upgrade-misc-improvements
branch
giorio94
added
the
backport-pending/1.13
9 tasks
jschwinger233
added
backport-pending/1.15
5 tasks
jschwinger233
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.13
This was referenced Apr 29, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.