endpoint: Skip build queue warning log is context is canceled #32132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning log on failure to queue endpoint build is most likely not
meaningful when the context is canceled, as this typically happends when
the endpoint is deleted.
Skip the warning log if error is context.Canceled. This fixes CI flakes
like this:
Found 1 k8s-app=cilium logs matching list of errors that must be investigated:
2024-04-22T07:48:47.779499679Z time="2024-04-22T07:48:47Z" level=warning msg="unable to queue endpoint build" ciliumEndpointName=kube-system/coredns-76f75df574-9k8sp containerID=3791acef13 containerInterface=eth0 datapathPolicyRevision=0 desiredPolicyRevision=0 endpointID=637 error="context canceled" identity=25283 ipv4=10.0.0.151 ipv6="fd02::82" k8sPodName=kube-system/coredns-76f75df574-9k8sp subsys=endpoint
Fixes: cilium#31827
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
release-note/misc
jrajahalme
added
needs-backport/1.13
needs-backport/1.14
|
/test |
aditighag
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
@jrajahalme Might be worthwhile to trigger ci-ginkgo (more specifically, K8sDatapathConfig test) a couple of times.
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
/ci-ginkgo |
gandro
added
backport-pending/1.15
gandro
added
backport-pending/1.14
gandro
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.14
github-actions
bot
added
the
backport-done/1.15
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning log on failure to queue endpoint build is most likely not meaningful when the context is canceled, as this typically happends when the endpoint is deleted.
Skip the warning log if error is context.Canceled. This fixes CI flakes like this:
Fixes: #31827