Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding custom labels to hubble UI deployment #33586

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Adding custom labels to hubble UI deployment #33586

merged 1 commit into from
Jul 8, 2024

Conversation

guanchzhou
Copy link
Contributor

This PR introduces additional labels for Hubble UI deployment helmchart.
It implements possibility to add some additional labels (e.g. team-name, cost-center, etc.) to Hubble UI deployment.

Fixes: #33582

@maintainer-s-little-helper
Copy link

Commit df6a3b0 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 4, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 4, 2024
@maintainer-s-little-helper
Copy link

Commits df6a3b0, 94b9b2b do not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@guanchzhou guanchzhou temporarily deployed to release-base-images July 4, 2024 12:43 — with GitHub Actions Inactive
@guanchzhou guanchzhou force-pushed the adding-custom-labels-to-hubble-ui-deployment branch from 94b9b2b to fca203e Compare July 4, 2024 12:51
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 4, 2024
@guanchzhou guanchzhou closed this Jul 4, 2024
@guanchzhou guanchzhou reopened this Jul 4, 2024
@guanchzhou guanchzhou marked this pull request as ready for review July 4, 2024 13:19
@guanchzhou guanchzhou requested review from a team as code owners July 4, 2024 13:19
@guanchzhou guanchzhou requested review from youngnick and gandro July 4, 2024 13:19
@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay area/helm Impacts helm charts and user deployment experience labels Jul 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 4, 2024
@gandro
Copy link
Member

gandro commented Jul 4, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 5, 2024
@gandro gandro force-pushed the adding-custom-labels-to-hubble-ui-deployment branch from fca203e to 65f7eb1 Compare July 8, 2024 08:16
@gandro
Copy link
Member

gandro commented Jul 8, 2024

Documentation workflow was failing due to a make -C Documentation update-helm-values missing. I've pushed it directly to the branch. Re-running CI.

@gandro
Copy link
Member

gandro commented Jul 8, 2024

/test

@gandro gandro force-pushed the adding-custom-labels-to-hubble-ui-deployment branch from 65f7eb1 to 33837b5 Compare July 8, 2024 08:34
@dylandreimerink dylandreimerink removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 8, 2024
@guanchzhou @gandro
Adding custom labels to hubble ui deployment
50a909e 
Fixes: cilium#33582

Signed-off-by: Andrey Maltsev <maltsev.andrey@gmail.com>
@gandro gandro force-pushed the adding-custom-labels-to-hubble-ui-deployment branch from 33837b5 to 50a909e Compare July 8, 2024 09:33
@gandro
Copy link
Member

gandro commented Jul 8, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 8, 2024
@dylandreimerink dylandreimerink added this pull request to the merge queue Jul 8, 2024
Merged via the queue into cilium:main with commit a7484dd Jul 8, 2024
66 checks passed
@guanchzhou guanchzhou deleted the adding-custom-labels-to-hubble-ui-deployment branch August 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick approved these changes

@gandro gandro gandro approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: adding custom labels to Hubble UI deployment helmchart
4 participants
@guanchzhou @gandro @youngnick @dylandreimerink