endpoint: move TestReadEpsFromDirNames to pkg/endpoint
#8997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianvernon
added
pending-review
kind/cleanup
ianvernon
changed the title
TestReadEpsFromDirNames\ to \pkg/endpoint\TestReadEpsFromDirNames to pkg/endpoint
ianvernon
force-pushed
the
pr/ianvernon/move-TestReadEPsFromDirNames-to-endpoint-pkg
branch
from
2f0dace
to
6b62f1e
Compare
|
test-me-please |
ianvernon
force-pushed
the
pr/ianvernon/move-TestReadEPsFromDirNames-to-endpoint-pkg
branch
from
6b62f1e
to
b6d0081
Compare
|
test-me-please |
ianvernon
force-pushed
the
pr/ianvernon/move-TestReadEPsFromDirNames-to-endpoint-pkg
branch
from
b6d0081
to
bcd40bf
Compare
|
test-me-please |
raybejjani
approved these changes
Aug 22, 2019
pkg/endpoint/endpoint_status_test.go
Outdated
| @@ -31,7 +31,6 @@ import ( | |||
| "github.com/cilium/cilium/pkg/labels" | |||
| "github.com/cilium/cilium/pkg/policy" | |||
| "github.com/cilium/cilium/pkg/policy/trafficdirection" | |||
|
|
|||
There was a problem hiding this comment.
This is unintended, I think?
The test was previously in `daemon`, and necessitated leaking a lot of Endpoint-related state. Instead, refactor the test into the Endpoint package. Do not regenerate the endpoints needed for testing; instead, write their headerfiles using `writeHeaderfile`, since that is the operation which is needed to be performed in order to perform the test to read the serialized Endpoints from their corresponding headerfiles. Signed-off by: Ian Vernon <ian@cilium.io>
ianvernon
force-pushed
the
pr/ianvernon/move-TestReadEPsFromDirNames-to-endpoint-pkg
branch
from
bcd40bf
to
852d91d
Compare
|
test-me-please |
ianvernon
deleted the
pr/ianvernon/move-TestReadEPsFromDirNames-to-endpoint-pkg
branch
aanm
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was previously in `daemon`, and necessitated leaking a lot of
Endpoint-related state. Instead, refactor the test into the Endpoint package.
Do not regenerate the endpoints needed for testing; instead, write their
headerfiles using `writeHeaderfile`, since that is the operation which
is needed to be performed in order to perform the test to read the serialized
Endpoints from their corresponding headerfiles.
Signed-off by: Ian Vernon ian@cilium.io
This change is