endpoint: do not export endpoint locking functions #9142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-me-please |
added 10 commits
September 6, 2019 08:16
…tapathMap` Callers should not be aware of the need to lock an Endpoint. Refactor `PinDatapathMap` to acquire the mutex and change callers accordingly. Signed-off by: Ian Vernon <ian@cilium.io>
These are no longer used outside of `pkg/endpoint`; do not export them. Signed-off by: Ian Vernon <ian@cilium.io>
Wrap locking + setting state in a function which does not require callers to lock the endpoint. Signed-off by: Ian Vernon <ian@cilium.io>
This is not used outside of `pkg/endpoint` any more; do not export it. Signed-off by: Ian Vernon <ian@cilium.io>
This is not used outside of `pkg/endpoint` any more; do not export it. Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Factor out the acquisition / releasing of mutexes into the endpoint package so that callers do not have to rely on accessing the endpoint's mutex. Signed-off by: Ian Vernon <ian@cilium.io>
This allows for endpoint locking to not need to be exposed to unit tests for `daemon`. Signed-off by: Ian Vernon <ian@cilium.io>
This is no longer used outside of `pkg/endpoint`; do not export it. Signed-off by: Ian Vernon <ian@cilium.io>
This is no longer used outside of `pkg/endpoint`; do not export it. Signed-off by: Ian Vernon <ian@cilium.io>
ianvernon
force-pushed
the
pr/ianvernon/do-not-export-endpoint-locks
branch
from
c68fe2b
to
459550c
Compare
|
test-me-please |
gandro
approved these changes
Sep 9, 2019
joestringer
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All locking functionality for the endpoint is now contained within
pkg/endpoint; do not export this functionality accordingly.This change is