-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ringbuf read on timeout #1111
Ringbuf read on timeout #1111
Conversation
770b493
to
455f1cb
Compare
455f1cb
to
0bc0582
Compare
Signed-off-by: Ron Federman <ronfederman@mail.tau.ac.il>
0bc0582
to
1e07890
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice, thanks! sampleMessage
is a good cleanup, we can use it to make discard behaviour more explicit. Left some comments around error handling and testing strategy.
Does it make sense to update Read
to mention this behaviour? Or maybe this is better documented on SetDeadline
?
Co-authored-by: Lorenz Bauer <lmb@users.noreply.github.com> Signed-off-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Thanks for you comments, |
Signed-off-by: Ron Federman <ronfederman@mail.tau.ac.il>
191bc74
to
d0bc6e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll squash your changes and merge once CI has passed.
The goal for this PR is describe in #1108