fix: add testcast for PutInteger #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
requested changes
Feb 5, 2024
atgane
force-pushed
the
feature/integer
branch
4 times, most recently
from
82fa5ac to
9733fef
Compare
atgane
force-pushed
the
feature/integer
branch
from
9733fef to
b1426a4
Compare
ti-mo
approved these changes
Feb 20, 2024
2 tasks
Fixes: cilium#1323 Signed-off-by: atgane <hyper201286@gmail.com> Co-authored-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
feature/integer
branch
from
b1426a4 to
f1155fc
Compare
|
@atgane I've squashed your commits and cut down on the size of the test suite. Try to avoid testing error strings, it's of questionable benefit and makes errors annoying to modify. I split off a few negative tests into TestPutIntegerError. |
Thank you for your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated the PR for #1277.