Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service map page: remove unnecessary scroll #784

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

yannikmesserli
Copy link
Contributor

@yannikmesserli yannikmesserli commented Feb 8, 2024

No issue.

Summary

No matter what, the service map page were showing a scroll on Chrome. This PR removes it.

Changes

  • Remove hidden elements from DOM's tree using display: none instead of visibilitiy: hidden

Screenshots

Before After
Screenshot 2024-02-08 at 11 51 25 Screenshot 2024-02-08 at 16 42 02

Functional testing

  • Open Hubble UI and select a namespace
  • Observe that the page does not have a scroll bar anymore on the entire body
  • !!!important!!! Verify that if you move your mouse over the "lock" icons, the tooltup is still displayed:
Screenshot 2024-02-08 at 16 40 40

I could not test the last part because I am not sure when those icons show up. using the default demo app, it is not showing up

@yannikmesserli yannikmesserli requested a review from a team as a code owner February 8, 2024 15:49
@yannikmesserli yannikmesserli requested review from kimstacy and removed request for a team February 8, 2024 15:49
@yannikmesserli yannikmesserli force-pushed the pr/yannik/no-useless-scroll branch from 69efe6e to 3ac0df7 Compare February 9, 2024 12:39
@geakstr geakstr merged commit b4ec0e3 into cilium:master Feb 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants