Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use pwru built by "make release" when testing #246

Closed
brb opened this issue Sep 5, 2023 · 0 comments · Fixed by #248
Closed

CI: use pwru built by "make release" when testing #246

brb opened this issue Sep 5, 2023 · 0 comments · Fixed by #248
Labels
help wanted Extra attention is needed testing

Comments

@brb
Copy link
Member

brb commented Sep 5, 2023

To avoid situations like #245
@brb brb added help wanted Extra attention is needed testing labels Sep 5, 2023
@brb brb mentioned this issue Sep 5, 2023
Merged
@brb brb closed this as completed in #248 Sep 5, 2023
qmonnet added a commit to qmonnet/pwru that referenced this issue Nov 22, 2023
@qmonnet
Makefile: Remove compiler versions for "make local-release"
ee54778 
This is a minor clean-up following the comment in the Makefile. Now that
cilium#246 was fixed in
cilium#248, the versions for clang and
GCC seem no longer necessary to display.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
brb pushed a commit that referenced this issue Dec 20, 2023
@qmonnet @brb
Makefile: Remove compiler versions for "make local-release"
9f5a386 
This is a minor clean-up following the comment in the Makefile. Now that
#246 was fixed in
#248, the versions for clang and
GCC seem no longer necessary to display.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh/workflows: Use "make release" to build pwru for testing cilium/pwru
1 participant
@brb