Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tetragon operator deployment into the helm chart #1351

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

prateek041
Copy link
Contributor

@prateek041 prateek041 commented Aug 11, 2023

In this PR:

  • Added service account, role bindings and cluster roles for the tetragon operator deployment.
  • This is disabled by default, to enable it, set the podWatcher.enabled field to true.

@prateek041 prateek041 requested a review from a team as a code owner August 11, 2023 12:24
@prateek041 prateek041 requested a review from tixxdz August 11, 2023 12:24
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall. 2 high-level points:

  • let's use tetragon-operator as the prefix for all the resources.
  • let's use tetragonPod.enabled as the single feature flag to toggle the TetragonPod feature.

also please run test.sh to fix the Lint helm chart / generated-files failure.

install/kubernetes/templates/_helpers.tpl Outdated Show resolved Hide resolved
install/kubernetes/templates/_helpers.tpl Outdated Show resolved Hide resolved
install/kubernetes/templates/_helpers.tpl Outdated Show resolved Hide resolved
install/kubernetes/templates/deployment.yaml Outdated Show resolved Hide resolved
install/kubernetes/templates/deployment.yaml Outdated Show resolved Hide resolved
install/kubernetes/templates/tpserviceaccount.yaml Outdated Show resolved Hide resolved
install/kubernetes/templates/tpserviceaccount.yaml Outdated Show resolved Hide resolved
install/kubernetes/templates/tpserviceaccount.yaml Outdated Show resolved Hide resolved
install/kubernetes/values.yaml Outdated Show resolved Hide resolved
my-values.yaml Outdated Show resolved Hide resolved
@prateek041 prateek041 requested a review from mtardy as a code owner August 11, 2023 16:57
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit a525bc4
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64d6b15beaa46a00083c3950
😎 Deploy Preview https://deploy-preview-1351--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michi-covalent michi-covalent self-requested a review August 11, 2023 20:27
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash into a single commit 🙏

install/kubernetes/templates/clusterrole.yaml Show resolved Hide resolved
install/kubernetes/templates/operator_clusterrole.yaml Outdated Show resolved Hide resolved
@michi-covalent michi-covalent force-pushed the feat/tetragonpod-helm-chart branch from f5ec297 to a525bc4 Compare August 11, 2023 22:08
Added service account, role bindings and cluster roles for the tetragon operator deployment.
This is disabled by default, to enable it, set the podWatcher.enabled field to true.

Signed-off-by: Prateek Singh <prateeksingh9741@gmail.com>
@prateek041 prateek041 force-pushed the feat/tetragonpod-helm-chart branch from 336949a to 40c2aa5 Compare August 12, 2023 15:56
@prateek041 prateek041 changed the title Integrate tetragonPod deployment into the tetragon Helm Charts Add tetragon operator deployment into the helm chart Aug 12, 2023
@kkourt kkourt merged commit 1b358ea into cilium:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants