Docs: Use URLs for kubectl apply demo commands instead of relative paths #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice thanks! Yeah I wrote the text before the github project was released thanks for the fixup. |
jrfastab
approved these changes
Jun 14, 2022
|
@dnsmichi can you add a Signed-off-by line to the commit please. |
Signed-off-by: Michael Friedrich <mfriedrich@gitlab.com>
|
@jrfastab Sorry, I forgot to read the contributing guide and the sign-off. Amended and force pushed :) |
|
FYI, we also talked about sending a docs PR in the recording :-) It has now been rendered in HD quality: https://www.youtube.com/watch?v=wv0AhY5-cJU |
|
docs PR is on my list for sure. Any and all help is greatly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
We've tested the Tetragon deployment for the first time in our #EveryoneCanContribute cafe meetup: https://everyonecancontribute.com/post/2022-06-16-cafe-52-learned-at-kubecon-eu-coffee-chat/
Some of the kubectl commands use relative paths which only work when you have the project cloned locally.
This PR changes all kubectl commands to using raw URLs and help smoothen the first impression, allowing to deploy and play < 15 minutes.