Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename TracingPolicy function #1915

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

sadath-12
Copy link
Contributor

@sadath-12 sadath-12 commented Dec 26, 2023

renaming waitForTracingPolicy to ensureTracingPolicy because that is what it does and the waiting part is done by WaitForTracingPolicy so we could import ensureTracingPolicy to other packages in future without confusions

Rename a function in e2e test helpers.

@sadath-12 sadath-12 requested a review from a team as a code owner December 26, 2023 06:29
@sadath-12 sadath-12 requested a review from tixxdz December 26, 2023 06:29
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jan 3, 2024
@lambdanis lambdanis self-assigned this Jan 3, 2024
@tixxdz
Copy link
Member

tixxdz commented Jan 3, 2024

Thanks @sadath-12 for the patch. Can you please copy the PR message into the commit message?

@sadath-12
Copy link
Contributor Author

Thank you @tixxdz

Renamed waitForTracingPolicy to ensureTracingPolicy because that is what it does and the waiting part is done by WaitForTracingPolicy so we could import ensureTracingPolicy to other packages in future without confusions

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tixxdz tixxdz merged commit 55dab8c into cilium:main Jan 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants