Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventchecker: fix type mismatch bug in argument checkers #240

Merged
merged 1 commit into from
Jul 22, 2022
Merged

eventchecker: fix type mismatch bug in argument checkers #240

merged 1 commit into from
Jul 22, 2022

Conversation

willfindlay
Copy link
Contributor

@willfindlay willfindlay commented Jul 15, 2022 •
edited
Loading

See commit messages

@willfindlay
Copy link
Contributor Author

Just beating up CI to see if we get any new checker failures from user error while writing tests. These would have been invisible before.

@willfindlay
eventchecker: fix type mismatch bug in argument checkers
a169293 
Our argument checkers were ignoring events of the wrong type. This is obviously not
correct, so let's handle it here.

Also had to make the following changes in our kprobe tests to fix old bugs that were
hiding due to incorrect argument type checking:

- kprobe_copyfd_test/TestCopyFd: StringArg -> FileArg
- kprobe_test/TestKprobe_char_iovec_returnCopy: IntArg -> SizeArg

Signed-off-by: William Findlay <will@isovalent.com>
@willfindlay willfindlay force-pushed the pr/willfindlay/fix-argument-checkers branch from 263174d to a169293 Compare July 15, 2022 22:02
@willfindlay willfindlay marked this pull request as ready for review July 15, 2022 22:13
@willfindlay willfindlay requested a review from a team as a code owner July 15, 2022 22:13
@tpapagian tpapagian mentioned this pull request Jul 18, 2022
Closed
tpapagian
tpapagian approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@tpapagian tpapagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkourt kkourt merged commit ef52d41 into main Jul 22, 2022
@kkourt kkourt deleted the pr/willfindlay/fix-argument-checkers branch July 22, 2022 07:21
This was referenced Jul 22, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@tpapagian tpapagian tpapagian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willfindlay @kkourt @tpapagian