Fix bugs in tracking bot's own usermodes #116

Merged
merged 2 commits into from Apr 13, 2013

Conversation

Projects
None yet
2 participants
@Elberet
Contributor

Elberet commented Apr 11, 2013

These changes fix two bugs in how the bot tracks its own usermodes:

  1. The @modes array retains its values between reconnect attempts; this results in modes not being set when the bot reconnects to IRC.
  2. When actively setting modes, modes are added a second time to @modes when Cinch::IRC handles the MODE message.
@dominikh

View changes

lib/cinch/bot.rb
@@ -265,6 +265,8 @@ def start(plugins = true)
}
end
+ @modes = []

This comment has been minimized.

Show comment Hide comment
@dominikh

dominikh Apr 13, 2013

Owner

We indent with spaces, not tabs. If you fix that, I can merge.

@dominikh

dominikh Apr 13, 2013

Owner

We indent with spaces, not tabs. If you fix that, I can merge.

@Elberet

This comment has been minimized.

Show comment Hide comment
@Elberet

Elberet Apr 13, 2013

Contributor

Now indenting with spaces, as requested. 😄

Contributor

Elberet commented Apr 13, 2013

Now indenting with spaces, as requested. 😄

dominikh added a commit that referenced this pull request Apr 13, 2013

Merge pull request #116 from Elberet/master
Fix bugs in tracking bot's own user modes

@dominikh dominikh merged commit 55b1633 into cinchrb:master Apr 13, 2013

@dominikh

This comment has been minimized.

Show comment Hide comment
@dominikh

dominikh Apr 13, 2013

Owner

Merged, thanks :)

Owner

dominikh commented Apr 13, 2013

Merged, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment