New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossplatform CMake support. #3

Merged
merged 2 commits into from Nov 7, 2018

Conversation

2 participants
@PetrosKataras
Copy link
Contributor

PetrosKataras commented Nov 6, 2018

This adds support for building Cinder-PortAudio through CMake on all supported platforms. Currently tested only on macOS but should also work on Linux and MSW. Depends on #2 for compilation to succeed.

@richardeakin

This comment has been minimized.

Copy link
Collaborator

richardeakin commented Nov 6, 2018

Sweet. :) Just wanted to check, the files in lib/cmake_support look like more than the cmake files that ship in pa_stable_v190600_20161030.tgz (this is where the portaudio source comes from), are they newer? Just want to keep track of where things are coming from, if we are shipping copied files.

Thanks for this, can't wait to try out JACK on linux next time I'm on that platform.

@PetrosKataras

This comment has been minimized.

Copy link
Contributor

PetrosKataras commented Nov 6, 2018

Yes, these files are from current master - could sync them if you would prefer although I believe these should be pretty harmless. Nice work, will allow to take advantage of more audio features in a cross-platform manner.

@PetrosKataras

This comment has been minimized.

Copy link
Contributor

PetrosKataras commented Nov 6, 2018

Versions should be in sync now :) Just one thing less to remember or having to write down I suppose.

@richardeakin

This comment has been minimized.

Copy link
Collaborator

richardeakin commented Nov 7, 2018

Okay will merge! Thanks, will also update the readme afterwards to say we now have support for more platforms. :)

If we find we need other features from master or a newer tag / release, we can update, I just would also like to keep this file up to date with whatever version we are using.

@richardeakin richardeakin merged commit 53723d7 into cinder:master Nov 7, 2018

@PetrosKataras PetrosKataras deleted the PetrosKataras:crossplatform-cmake-support branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment