Skip to content

Commit 6ef39c5

Browse files
committed
Removed unnecessary pass by refernce for ImageTargetGlTexture
1 parent ef82545 commit 6ef39c5

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/cinder/gl/Texture.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ class ImageTargetTexture;
106106
template<typename T>
107107
class ImageTargetGlTexture : public ImageTarget {
108108
public:
109-
static shared_ptr<ImageTargetGlTexture> create( const Texture *texture, ImageIo::ChannelOrder &channelOrder, bool isGray, bool hasAlpha );
109+
static shared_ptr<ImageTargetGlTexture> create( const Texture *texture, ImageIo::ChannelOrder channelOrder, bool isGray, bool hasAlpha );
110110
#if ! defined( CINDER_GL_ES )
111111
// receives a pointer to an intermediate data store, presumably a mapped PBO
112-
static shared_ptr<ImageTargetGlTexture> create( const Texture *texture, ImageIo::ChannelOrder &channelOrder, bool isGray, bool hasAlpha, void *data );
112+
static shared_ptr<ImageTargetGlTexture> create( const Texture *texture, ImageIo::ChannelOrder channelOrder, bool isGray, bool hasAlpha, void *data );
113113
#endif
114114

115115
virtual bool hasAlpha() const { return mHasAlpha; }
@@ -118,7 +118,7 @@ class ImageTargetGlTexture : public ImageTarget {
118118
void* getData() const { return mDataBaseAddress; }
119119

120120
private:
121-
ImageTargetGlTexture( const Texture *texture, ImageIo::ChannelOrder &channelOrder, bool isGray, bool hasAlpha, void *intermediateData );
121+
ImageTargetGlTexture( const Texture *texture, ImageIo::ChannelOrder channelOrder, bool isGray, bool hasAlpha, void *intermediateData );
122122

123123
const Texture *mTexture;
124124
bool mHasAlpha;
@@ -2138,22 +2138,22 @@ void TextureCubeMap::printDims( std::ostream &os ) const
21382138
/////////////////////////////////////////////////////////////////////////////////
21392139
// ImageTargetGlTexture
21402140
template<typename T>
2141-
shared_ptr<ImageTargetGlTexture<T>> ImageTargetGlTexture<T>::create( const Texture *texture, ImageIo::ChannelOrder &channelOrder, bool isGray, bool hasAlpha )
2141+
shared_ptr<ImageTargetGlTexture<T>> ImageTargetGlTexture<T>::create( const Texture *texture, ImageIo::ChannelOrder channelOrder, bool isGray, bool hasAlpha )
21422142
{
21432143
return shared_ptr<ImageTargetGlTexture<T>>( new ImageTargetGlTexture<T>( texture, channelOrder, isGray, hasAlpha, nullptr ) );
21442144
}
21452145

21462146
#if ! defined( CINDER_GL_ES )
21472147
// create method receives an existing pointer which presumably is a mapped PBO
21482148
template<typename T>
2149-
shared_ptr<ImageTargetGlTexture<T>> ImageTargetGlTexture<T>::create( const Texture *texture, ImageIo::ChannelOrder &channelOrder, bool isGray, bool hasAlpha, void *intermediateDataStore )
2149+
shared_ptr<ImageTargetGlTexture<T>> ImageTargetGlTexture<T>::create( const Texture *texture, ImageIo::ChannelOrder channelOrder, bool isGray, bool hasAlpha, void *intermediateDataStore )
21502150
{
21512151
return shared_ptr<ImageTargetGlTexture<T>>( new ImageTargetGlTexture<T>( texture, channelOrder, isGray, hasAlpha, intermediateDataStore ) );
21522152
}
21532153
#endif
21542154

21552155
template<typename T>
2156-
ImageTargetGlTexture<T>::ImageTargetGlTexture( const Texture *texture, ImageIo::ChannelOrder &channelOrder, bool isGray, bool hasAlpha, void *intermediateDataStore )
2156+
ImageTargetGlTexture<T>::ImageTargetGlTexture( const Texture *texture, ImageIo::ChannelOrder channelOrder, bool isGray, bool hasAlpha, void *intermediateDataStore )
21572157
: ImageTarget(), mTexture( texture ), mHasAlpha( hasAlpha )
21582158
{
21592159
if( isGray ) {

0 commit comments

Comments
 (0)