Get rid of most warnings building OSC block

- this were particularly verbose on Windows, related to possible loss
  of data during size conversions (size_t to int32_t or uint32_t).
- there are still a few other warnings, but fixing those may require
  replacing/updating the ASIO library.

Author: totalgee

blocks/OSC/src/cinder/osc/Osc.cpp

@@ -312,7 +312,9 @@ void Message::append( const std::string& v )
 	mIsCached = false;
 	auto trailingZeros = getTrailingZeros( v.size() );
 	auto size = v.size() + trailingZeros;
-	mDataViews.emplace_back( this, ArgType::STRING, getCurrentOffset(), size );
+	CI_ASSERT_MSG( size <= std::numeric_limits<uint32_t>::max(),
+		"Argument size must fit in uint32_t" );
+	mDataViews.emplace_back( this, ArgType::STRING, getCurrentOffset(), static_cast<uint32_t>( size ) );
 	appendDataBuffer( v.data(), v.size(), trailingZeros );
 }
 
@@ -322,7 +324,9 @@ void Message::append( const char *v )
 	auto stringLength = strlen( v );
 	auto trailingZeros = getTrailingZeros( stringLength );
 	auto size = stringLength + trailingZeros;
-	mDataViews.emplace_back( this, ArgType::STRING, getCurrentOffset(), size );
+	CI_ASSERT_MSG( size <= std::numeric_limits<uint32_t>::max(),
+		"Argument size must fit in uint32_t" );
+	mDataViews.emplace_back( this, ArgType::STRING, getCurrentOffset(), static_cast<uint32_t>( size ) );
 	appendDataBuffer( v, stringLength, trailingZeros );
 }
 
@@ -337,7 +341,9 @@ void Message::appendBlob( void* blob, uint32_t size )
 
 void Message::append( const ci::Buffer &buffer )
 {
-	appendBlob( (void*)buffer.getData(), buffer.getSize() );
+	CI_ASSERT_MSG( buffer.getSize() <= std::numeric_limits<uint32_t>::max(),
+		"Blob size must fit in uint32_t" );
+	appendBlob( (void*)buffer.getData(), static_cast<uint32_t>( buffer.getSize() ) );
 }
 
 void Message::appendTimeTag( uint64_t v )
@@ -418,7 +424,9 @@ void Message::createCache() const
 
 	size_t typesArrayLen = typesArray.size();
 	ByteArray<4> sizeArray;
-	int32_t messageSize = addressLen + typesArrayLen + mDataBuffer.size();
+	CI_ASSERT_MSG( addressLen + typesArrayLen + mDataBuffer.size() <= std::numeric_limits<int32_t>::max(),
+		"Message size must fit in int32_t" );
+	int32_t messageSize = static_cast<int32_t>(addressLen + typesArrayLen + mDataBuffer.size());
 	auto endianSize = htonl( messageSize );
 	memcpy( sizeArray.data(), reinterpret_cast<uint8_t*>( &endianSize ), 4 );
 
@@ -455,7 +463,7 @@ const Argument& Message::getDataView( uint32_t index ) const
 	return mDataViews[index];
 }
 
-void Message::appendDataBuffer( const void *begin, uint32_t size, uint32_t trailingZeros )
+void Message::appendDataBuffer( const void *begin, size_t size, uint32_t trailingZeros )
 {
 	auto ptr = reinterpret_cast<const uint8_t*>( begin );
 	mDataBuffer.insert( mDataBuffer.end(), ptr, ptr + size );
@@ -1363,7 +1371,9 @@ void ReceiverUdp::listen( OnSocketErrorFn onSocketErrorFn )
 			data[ bytesTransferred ] = 0;
 			istream stream( &mBuffer );
 			stream.read( reinterpret_cast<char*>( data.get() ), bytesTransferred );
-			dispatchMethods( data.get(), bytesTransferred, uniqueEndpoint->address(), uniqueEndpoint->port() );
+			CI_ASSERT_MSG( bytesTransferred <= std::numeric_limits<uint32_t>::max(),
+				"Dispatch size must fit in uint32_t" );
+			dispatchMethods( data.get(), static_cast<uint32_t>( bytesTransferred ), uniqueEndpoint->address(), uniqueEndpoint->port() );
 		}
 		listen( std::move( onSocketErrorFn ) );
 	});
@@ -1468,7 +1478,9 @@ void ReceiverTcp::Connection::read()
 				dataSize = data->size() - 4;
 			}
 
-			receiver->dispatchMethods( dataPtr, dataSize, mSocket->remote_endpoint().address(), mSocket->remote_endpoint().port() );
+			CI_ASSERT_MSG( dataSize <= std::numeric_limits<uint32_t>::max(),
+				"Dispatch size must fit in uint32_t" );
+			receiver->dispatchMethods( dataPtr, static_cast<uint32_t>( dataSize ), mSocket->remote_endpoint().address(), mSocket->remote_endpoint().port() );
 
 			read();
 		}
@@ -1740,7 +1752,13 @@ void getDate( uint64_t ntpTime, uint32_t *year, uint32_t *month, uint32_t *day,
 	// Convert to unix timestamp.
 	std::time_t sec_since_epoch = ( ntpTime - ( uint64_t( 0x83AA7E80 ) << 32 ) ) >> 32;
 
-	auto tm = std::localtime( &sec_since_epoch );
+#ifdef CINDER_MSW
+	struct tm tm_buf{};
+	localtime_s( &tm_buf, &sec_since_epoch );
+	auto tm = &tm_buf;
+#else
+	auto tm = std::localtime(&sec_since_epoch);
+#endif // CINDER_MSW
 	if( year ) *year = tm->tm_year + 1900;
 	if( month ) *month = tm->tm_mon + 1;
 	if( day ) *day = tm->tm_mday;
@@ -1756,10 +1774,16 @@ std::string getClockString( uint64_t ntpTime, bool includeDate )
 
 	char buffer[128];
 
+#ifdef CINDER_MSW
+#define SPRINTF sprintf_s
+#else
+#define SPRINTF sprintf
+#endif // CINDER_MSW
+
 	if( includeDate )
-		sprintf( buffer, "%d/%d/%d %02d:%02d:%02d", month, day, year, hours, minutes, seconds );
+		SPRINTF( buffer, "%d/%d/%d %02d:%02d:%02d", month, day, year, hours, minutes, seconds );
 	else
-		sprintf( buffer, "%02d:%02d:%02d", hours, minutes, seconds );
+		SPRINTF( buffer, "%02d:%02d:%02d", hours, minutes, seconds );
 
 	return std::string( buffer );
 }

blocks/OSC/src/cinder/osc/Osc.h

@@ -289,7 +289,11 @@ class Message {
 	//! Helper to calculate how many zeros to buffer to create a 4 byte
 	static uint8_t getTrailingZeros( size_t bufferSize ) { return 4 - ( bufferSize % 4 ); }
 	//! Helper to get current offset into the buffer.
-	size_t getCurrentOffset() { return mDataBuffer.size(); }
+	int32_t getCurrentOffset() {
+		CI_ASSERT_MSG( mDataBuffer.size() <= std::numeric_limits<int32_t>::max(),
+			"Argument offset must fit in int32_t" );
+		return static_cast<int32_t>( mDataBuffer.size() );
+	}
 	//! Helper to retrieve the data view of an Argument. Checks the type provided and
 	//! throws ExcNonConvertible if data view cannot convert the type.
 	template<typename T>
@@ -323,7 +327,7 @@ class Message {
 
 	//! Helper to to insert data starting at \a begin for \a with resize/fill in the amount
 	//! of \a trailingZeros
-	void appendDataBuffer( const void *begin, uint32_t size, uint32_t trailingZeros = 0 );
+	void appendDataBuffer( const void *begin, size_t size, uint32_t trailingZeros = 0 );
 
 	//! Returns a complete byte array of this OSC message as a ByteBufferRef type.
 	//! The byte buffer is constructed lazily and is cached until the cache is