Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove JsonTree from cinder.lib #2092

Open
richardeakin opened this issue May 7, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@richardeakin
Copy link
Collaborator

commented May 7, 2019

I believe this is our last dependency on boost for toolsets that contain <filesystem> and <system> (almost all of them). Many of us have stopped using it already in favor of either using the already-shipped jsoncpp directly, or any other C++ json library of their choice.

There are some samples that use JsonTree still, I think we should update those to use jsoncpp. There's also a (not very good) unit test for it that we need to remove.

Should we move ci::JsonTree somewhere so that projects that are using it can continue to do so after updating cinder? Maybe someone would be up for hosting a cinderblock that contains ci::JsonTree?

@brucelane

This comment has been minimized.

Copy link

commented May 7, 2019

I use it a lot, but removing dependency on boost is more important.
I could do a Cinder block for it, but not sure I would succeed...

@paulhoux

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

I'm all for removing it. It's much easier to just use the jsoncpp library directly. Like you said, most of us have been doing that for years now. No use keeping code that makes things worse, instead of better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.