New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GLES/EGL on Linux #1943

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Projects
None yet
2 participants
@thyrrestrup

thyrrestrup commented Dec 12, 2017

This fixes GLES on EGL Context through GLFW on Linux.
I've removed a couple of deprecated _GLFW_ macros and added the appropriate glfwWindowHint for EGL context creation.
Also glx_context.c was added as it is needed in both the GLX and EGL context case.

Tobias Thyrrestrup
@thyrrestrup

This comment has been minimized.

Show comment
Hide comment
@richardeakin

This comment has been minimized.

Show comment
Hide comment
@richardeakin

richardeakin Dec 29, 2017

Collaborator

This all looks good to me, thanks for explaining all of the changes. I don't have a machine where I can test at the moment but it appears from the forum post that this is fixing a few people's problems so I think we should merge it soon.

Collaborator

richardeakin commented Dec 29, 2017

This all looks good to me, thanks for explaining all of the changes. I don't have a machine where I can test at the moment but it appears from the forum post that this is fixing a few people's problems so I think we should merge it soon.

@richardeakin richardeakin added the linux label Dec 29, 2017

@thyrrestrup

This comment has been minimized.

Show comment
Hide comment
@thyrrestrup

thyrrestrup Dec 29, 2017

I've tested the changes running the latest Debian with Gnome desktop on the latest Mac Mini and on the UP Squared board both with and without GLES.

thyrrestrup commented Dec 29, 2017

I've tested the changes running the latest Debian with Gnome desktop on the latest Mac Mini and on the UP Squared board both with and without GLES.

@richardeakin richardeakin merged commit bb023f9 into cinder:master Jan 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thyrrestrup thyrrestrup deleted the thyrrestrup:fixGlesEglLinux branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment