Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid ZoneId test on Scala.js #1305

Open
travisbrown opened this issue Oct 22, 2019 · 1 comment
Open

Fix invalid ZoneId test on Scala.js #1305

travisbrown opened this issue Oct 22, 2019 · 1 comment

Comments

@travisbrown
Copy link
Member

@travisbrown travisbrown commented Oct 22, 2019

This test intermittently fails on Scala.js with scala-java-time (running sbt validateJS):

[info] Decoder[ZoneId]
[info] - should fail for invalid ZoneId *** FAILED ***
[info]   TestFailedException was thrown during property evaluation.
[info]     Message: decodingResult.swap.exists(((x$6: io.circe.DecodingFailure) => x$6.message.contains(scala.StringContext.apply(", invalid format: ", ")").s(s)))) was false
[info]     Location: (JavaTimeCodecSuite.scala:143)
[info]     Occurred when passed generated values (
[info]       arg0 = "" // 13 shrinks
[info]     )

This is because of scala-java-time's error messages for ZoneId, which is arguably a bug there. We don't run validateJS in CI, so it's not a big deal, but it would be nicer for contributors who are running the Scala.js tests if we could work around the scala-java-time bug until it's fixed.

@tmccarthy
Copy link
Contributor

@tmccarthy tmccarthy commented May 25, 2020

This issue has been fixed by the upgrade of scala-java-time to 2.0.0 in #1448. The corresponding scala-java-time PR is cquiroz/scala-java-time#133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants