Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value of the implicit class private #1291

Merged
merged 1 commit into from Oct 22, 2019
Merged

Conversation

implmnt
Copy link
Contributor

@implmnt implmnt commented Oct 11, 2019

Since circe has dropped support for scala 2.10, there is no reason to use public val's in AnyVal implicit classes.
This should fix potential collisions with user defined fields (key, wrappedEncodeable)

See a similar issue in cats

@codecov-io
Copy link

Codecov Report

Merging #1291 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
- Coverage   85.91%   85.75%   -0.16%     
==========================================
  Files          74       74              
  Lines        2535     2535              
  Branches      108      108              
==========================================
- Hits         2178     2174       -4     
- Misses        357      361       +4
Impacted Files Coverage Δ
...hared/src/main/scala/io/circe/syntax/package.scala 100% <ø> (ø) ⬆️
...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala 91.66% <0%> (-8.34%) ⬇️
modules/rs/src/main/scala/io/circe/rs/JsonF.scala 94.11% <0%> (-5.89%) ⬇️
...c/main/scala/io/circe/tests/examples/package.scala 94.11% <0%> (-4.42%) ⬇️
.../core/shared/src/main/scala/io/circe/Decoder.scala 85.25% <0%> (-0.27%) ⬇️
...re/shared/src/main/scala/io/circe/JsonNumber.scala 93.97% <0%> (+1.2%) ⬆️
...les/core/shared/src/main/scala/io/circe/Json.scala 78.78% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76326b...451141c. Read the comment docs.

@implmnt implmnt changed the title Make the value of the implicit class private Make value of the implicit class private Oct 11, 2019
@travisbrown
Copy link
Member

@implmnt Thanks for catching this! Will get it merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants