Support printing to arbitrary Writers#537
Conversation
Current coverage is 82.67% (diff: 100%)@@ master #537 diff @@
==========================================
Files 70 70
Lines 1974 2014 +40
Methods 1828 1874 +46
Messages 0 0
Branches 146 140 -6
==========================================
+ Hits 1623 1665 +42
+ Misses 351 349 -2
Partials 0 0
|
| printJsonAtDepth(writer)(json, 0) | ||
|
|
||
| writer.close() | ||
| bytes.toByteArray |
There was a problem hiding this comment.
I wish we could avoid copying here. Even though there is no API to retrieve the underlying buffer directly, people seem to use this simple trick to do that. Please, note that this means we'd need to change the return type to ByteBuffer since the underlying Array[Byte] may contain more bytes than we need so we have to crop it.
I think we can also expose that as a standalone method (printByteBuffer) if we're worried about this extra complexity. What do you think @travisbrown?
|
Ah, good point, @vkostyukov. I've just pushed an update—what do you think? |
|
Looks great! I really like how simple |
|
Ugh, was just running Scala.js tests for the 0.7.0-M2 release and get this: [error] Referring to non-existent method java.io.BufferedWriter.<init>(java.io.Writer)
[error] called from io.circe.Printer.prettyByteBuffer(io.circe.Json)java.nio.ByteBufferI guess we'll have to make this a JVM-only method—I'll get started on that asap. |
3 participants
Addresses #536. In addition to the new
prettyBytesI've made a few other small changes that simplify things a bit and seem to give us a few percent more throughput in the benchmarks.I'm not currently exposing the ability for users to print to their own
Appendables. I'm not totally opposed to the idea, but I'd prefer not to add methods that are fundamentally about mutation unless there's a really clear need.