Clarify description of deploy key with write access #4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for this @jdblischak! 🎉 |
rosieyohannan
approved these changes
Feb 6, 2020
jdblischak
added a commit
to jdblischak/blog.jdblischak.com
that referenced
this pull request
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the reference to "user key" in the description of a deploy key with write access.
Reasons
In this one place in the documentation, it implies that a deploy key with write access is a "user key". This really confused me. This PR updates this section to be consistent with the rest of the documentation of deploy vs user keys.
Also, I indented the paragraph from PR #2958 to fix the numbering of the markdown list. Currently it is 1-1-2-3 when it should be 1-2-3-4.
cc: @pat-s