Fixes expectRevert not checking revert string #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue to web3 upgrade
…00 in new truffle null address
o-a-hudson
force-pushed
the
multi-issuer
branch
from
b3c51b4
to
31fa691
Compare
eztierney
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixes expectRevert not checking expectedErrorMessage == actualErrorMessage
-Fixes revert string in tests inconsistent with revert string in contract
-Adds missing await in test
-Makes revert string use plural noun to match solidity variable
-Fixes 0x0 address throwing errors (replaces will full null address) due to upgrade in web3
-Upgrades ganache-cli used